From: Sasha Levin <Alexander.Levin@microsoft.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Anton Vasilyev <vasilyev@ispras.ru>,
Aleksandar Markovic <aleksandar.markovic@mips.com>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Goran Ferenc <goran.ferenc@mips.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sasha Levin <Alexander.Levin@microsoft.com>
Subject: [PATCH AUTOSEL 3.18 10/19] video: goldfishfb: fix memory leak on driver remove
Date: Fri, 7 Sep 2018 00:39:33 +0000 [thread overview]
Message-ID: <20180907003923.58019-10-alexander.levin@microsoft.com> (raw)
In-Reply-To: <20180907003923.58019-1-alexander.levin@microsoft.com>
From: Anton Vasilyev <vasilyev@ispras.ru>
[ Upstream commit 5958fde72d04e7b8c6de3669d1f794a90997e3eb ]
goldfish_fb_probe() allocates memory for fb, but goldfish_fb_remove() does
not have deallocation of fb, which leads to memory leak on probe/remove.
The patch adds deallocation into goldfish_fb_remove().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
drivers/video/fbdev/goldfishfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 7f6c9e6cfc6c..14a93cb21310 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -301,6 +301,7 @@ static int goldfish_fb_remove(struct platform_device *pdev)
dma_free_coherent(&pdev->dev, framesize, (void *)fb->fb.screen_base,
fb->fb.fix.smem_start);
iounmap(fb->reg_base);
+ kfree(fb);
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2018-09-07 0:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 0:39 [PATCH AUTOSEL 3.18 01/19] ALSA: msnd: Fix the default sample sizes Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 02/19] ALSA: usb-audio: Fix multiple definitions in AU0828_DEVICE() macro Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 03/19] xfrm: fix 'passing zero to ERR_PTR()' warning Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 04/19] gfs2: Special-case rindex for gfs2_grow Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 05/19] MIPS: ath79: fix system restart Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 06/19] mtd/maps: fix solutionengine.c printk format warnings Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 07/19] gfs2: Don't reject a supposedly full bitmap if we have blocks reserved Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 08/19] iio: ad9523: Fix displayed phase Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 09/19] fbdev: omapfb: off by one in omapfb_register_client() Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 11/19] fbdev/via: fix defined but not used warning Sasha Levin
2018-09-07 0:39 ` Sasha Levin [this message]
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 12/19] perf powerpc: Fix callchain ip filtering when return address is in a register Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 14/19] perf powerpc: Fix callchain ip filtering Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 13/19] fbdev: Distinguish between interlaced and progressive modes Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 15/19] powerpc/powernv: opal_put_chars partial write fix Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 16/19] mac80211: restrict delayed tailroom needed decrement Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 17/19] s390/qeth: fix race in used-buffer accounting Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 18/19] s390/qeth: reset layer2 attribute on layer switch Sasha Levin
2018-09-07 0:39 ` [PATCH AUTOSEL 3.18 19/19] platform/x86: toshiba_acpi: Fix defined but not used build warnings Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907003923.58019-10-alexander.levin@microsoft.com \
--to=alexander.levin@microsoft.com \
--cc=aleksandar.markovic@mips.com \
--cc=b.zolnierkie@samsung.com \
--cc=goran.ferenc@mips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miodrag.dinic@mips.com \
--cc=stable@vger.kernel.org \
--cc=vasilyev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome