From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C829C4321E for ; Fri, 7 Sep 2018 05:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A73CA20869 for ; Fri, 7 Sep 2018 05:18:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A73CA20869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727598AbeIGJ5c (ORCPT ); Fri, 7 Sep 2018 05:57:32 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:55689 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbeIGJ5c (ORCPT ); Fri, 7 Sep 2018 05:57:32 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.08580496|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03309;MF=ren_guo@c-sky.com;NM=1;PH=DS;RN=11;RT=11;SR=0;TI=SMTPD_---.CnYt5vt_1536297468; Received: from localhost(mailfrom:ren_guo@c-sky.com fp:SMTPD_---.CnYt5vt_1536297468) by smtp.aliyun-inc.com(10.147.41.231); Fri, 07 Sep 2018 13:17:48 +0800 Date: Fri, 7 Sep 2018 13:17:47 +0800 From: Guo Ren To: Arnd Bergmann Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu Subject: Re: [PATCH V3 17/26] csky: Misc headers Message-ID: <20180907051747.GC13356@guoren-Inspiron-7460> References: <66335e5f59c186b291f8c3c98c9dadbd61d0cd3e.1536138304.git.ren_guo@c-sky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 06, 2018 at 04:16:30PM +0200, Arnd Bergmann wrote: > On Wed, Sep 5, 2018 at 2:08 PM Guo Ren wrote: > > > diff --git a/arch/csky/boot/dts/qemu.dts b/arch/csky/boot/dts/qemu.dts > > new file mode 100644 > > index 0000000..d36e4cd > > --- /dev/null > > +++ b/arch/csky/boot/dts/qemu.dts > > @@ -0,0 +1,77 @@ > > +/dts-v1/; > > +/ { > > + compatible = "csky,qemu"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + interrupt-parent = <&intc>; > > Ideally, qemu would supply a dtb file that matches the current configuration, > as we do for instance on the ARM 'virt' machine. This allows you > much more flexibility in running all kinds of options, as well as extending > qemu later with new features. So, I should remove qemu.dts in next version patch? > > + > > + timer0: timer@0xffffd000 { > > + compatible = "snps,dw-apb-timer"; > > + reg = <0xffffd000 0x1000>; > > + clocks = <&dummy_apb>; > > + clock-names = "timer"; > > + interrupts = <1>; > > + }; > > + > > + timer1: timer@0xffffd014 { > > Drop the leading '0x' in the unit-address here (in all devices) Ok