From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6784DC433F5 for ; Fri, 7 Sep 2018 12:00:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F9652077C for ; Fri, 7 Sep 2018 12:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="a2E6OmUC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F9652077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729009AbeIGQlR (ORCPT ); Fri, 7 Sep 2018 12:41:17 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:59704 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728172AbeIGQlQ (ORCPT ); Fri, 7 Sep 2018 12:41:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uQ5Yz61x9Q60BUqyPVPDHQRc+eOIEJYK7TkYPPCyRW4=; b=a2E6OmUC5F7kPF0jxtcSoOJXt jybAgXRQ+27qCiApur3qHaVcAm4AexUGvEkTHXX2Cy4i6BXAcXQW2N2pOCB/i4S1fnS5phPrqEaU4 WjdMGpA2MQXA3zvj8aRJ3XtG8V5sF3puHkqLU/ndV85f9d7L0kqaFlAwg/Ogd5QDXyQQA=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fyFRD-0005Oi-6T; Fri, 07 Sep 2018 12:00:35 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id B86A11122A6D; Fri, 7 Sep 2018 13:00:34 +0100 (BST) Date: Fri, 7 Sep 2018 13:00:34 +0100 From: Mark Brown To: "Agrawal, Akshu" Cc: Sasha Levin , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function Message-ID: <20180907120034.GF17459@sirena.org.uk> References: <20180902064601.183036-1-alexander.levin@microsoft.com> <20180902064601.183036-43-alexander.levin@microsoft.com> <20180903111626.GC10302@sirena.org.uk> <20180907002313.GB16300@sasha-vm> <056779f2-8b3b-63b5-ce0b-f314317156f7@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Content-Disposition: inline In-Reply-To: <056779f2-8b3b-63b5-ce0b-f314317156f7@amd.com> X-Cookie: Do not fold, spindle or mutilate. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 07, 2018 at 12:46:21PM +0530, Agrawal, Akshu wrote: > But more likely I think the delay was just getting left out and there > wouldn't have been a compensation in userspace. Yes, I don't think most users are going to notice this either way - the overwhelming majority of them won't have noticed a problem and won't notice the fix going in. It's then a question of if the people who saw the issue and cared did the userspace compenstation or not, my concern is that more will have done than won't given that it's a fairly common thing to have control for given that you also often get delays added in things like surround sound systems which aren't visible to the playback device. --hK8Uo4Yp55NZU70L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAluSaGEACgkQJNaLcl1U h9CE1Af+NM9Fb5vr16bfvI0/wSOnxQ60fQ6rH2hi3N3hglwoL1aEB3Ab38LRDEP/ b8mpz+Zv2LB4wFgSy3e7azi/XlOh2KSF1ODy6vG1P/JY2gKzaHjGjRYzQR8WdJ2X skp7E8DR6MnEifShJSxwZRur6jMxxaI03Ue1xUHjHDByUSRUYXVPfyxan+6oBD3j kpFzuW7aBvBBBv26WgNDcYbhnKDbu1J7H8CvrSogbnlI21iPTsZM0xntDIosbKw+ M/N8EtnFuGUXKkks79A+E4TGUuULqSR5Pg3G29wh67exH7i15kPv1BkZk0NZgwDr OyPkNpedjNXmVkJa+QbCTgNI2avEgg== =sos1 -----END PGP SIGNATURE----- --hK8Uo4Yp55NZU70L--