From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH 2/2] pci: dwc: add UniPhier PCIe host controller support
Date: Fri, 07 Sep 2018 13:11:27 +0900 [thread overview]
Message-ID: <20180907131126.FACD.4A936039@socionext.com> (raw)
In-Reply-To: <20180906140926.GB214747@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Thu, 6 Sep 2018 09:09:27 -0500 <helgaas@kernel.org> wrote:
> On Thu, Sep 06, 2018 at 10:38:20AM +0900, Kunihiko Hayashi wrote:
> > > > +++ b/drivers/pci/controller/dwc/pcie-uniphier.c
> > > > @@ -0,0 +1,464 @@
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +//
> > > > +// PCI-express host controller driver for UniPhier SoCs
> > > > +// Copyright 2018 Socionext Inc.
> > > > +// Author: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> > >
> > > Use /* ... */ comments except for the SPDX line.
> >
> > Okay, although I wondered which way to put, I'll replace the header next.
>
> The easiest thing is to look at similar files already in the tree and
> follow their style. The details are here:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n540
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst#n74
Thanks for your advice.
Although I've found both styles in some sub-systems, these are helpful for me.
I replaced it in posted v2.
Thank you,
---
Best Regards,
Kunihiko Hayashi
prev parent reply other threads:[~2018-09-07 4:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 2:32 [PATCH 0/2] add new UniPhier PCIe host driver Kunihiko Hayashi
2018-09-05 2:32 ` [PATCH 1/2] dt-bindings: pci: add UniPhier PCIe host controller description Kunihiko Hayashi
2018-09-05 17:21 ` Bjorn Helgaas
2018-09-06 1:38 ` Kunihiko Hayashi
2018-09-05 2:32 ` [PATCH 2/2] pci: dwc: add UniPhier PCIe host controller support Kunihiko Hayashi
2018-09-05 17:25 ` Bjorn Helgaas
2018-09-06 1:38 ` Kunihiko Hayashi
2018-09-06 14:09 ` Bjorn Helgaas
2018-09-07 4:11 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907131126.FACD.4A936039@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®