From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE38C4321E for ; Sat, 8 Sep 2018 21:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79B3E20868 for ; Sat, 8 Sep 2018 21:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kWpv5uCp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79B3E20868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728001AbeIICM3 (ORCPT ); Sat, 8 Sep 2018 22:12:29 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36177 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727675AbeIICM2 (ORCPT ); Sat, 8 Sep 2018 22:12:28 -0400 Received: by mail-wm0-f65.google.com with SMTP id j192-v6so17780952wmj.1; Sat, 08 Sep 2018 14:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oAXPr8ETaa7/32NYIRLN7FQZn0P9Pjw91VuXQcuTRrQ=; b=kWpv5uCpl5l9YTuof4H7BS+m9yPduJZ0jSBabZj2zObW2y3kY5GLjTfPM4j1zhVMKI LHoWmHMVKGFS+XNQsDVWFp+DwsX2RehOkDqJAI21wX+ovdCbJiTrMmsLM+jBO51TcfJF hVEBXwFEIrueDIDKWAuKiLuKiBH6YFyQWqjCibKyS9xs5oY9KBlrZ+abd68szdfHS/bR uKgK0vgqznPpqi6anQV3GUfOd849d739uraLVxcHk6TEl07I2L7yZfb6UgyWXMR0cL5t RqAoiGF2JSI1TuiAQP9Nq9hBEcEIxXE/k+ol1aZ+56bBr2DCc3OUlnyQ/dYeJ78348tz 6hlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oAXPr8ETaa7/32NYIRLN7FQZn0P9Pjw91VuXQcuTRrQ=; b=IeNKOUGkuOgdBwxxxwZvUl7wFgQ+Oe59ZF2FaJMJwLWWsejcehR/6ywCIbrNC0stLT +i7j8fcM73tN3UUWgLYP4gA1n1IHv/4IcrXihPNFpmXYhK3zb4gIZRudvRLEGdXBYnOZ czs90K/3EnS+JVrUawAzNFfoNkieDERxcCeqxPe931cxN3TKubjKNbQ+2Q2BVMpgzUc7 N3hKp2JenbOJyAtNZI5Ze3NxwGGXXmxDDaxuUh9SC0oG4aZqkpdimccsm/sAM3qj7D9J gBfkUuqOWAMTr4On0HG52l1r+/U6vtENpfjT8IQeepW6XwabaxVmPgk5gPc7pWTH4xUo 2Afw== X-Gm-Message-State: APzg51ADWp1BNuvlmd3/9Ml2AeNqrPrKezoRT5CFF82/wCg0ZFGmidPX QfINJ5BkMTN7XqQBTELL5cs= X-Google-Smtp-Source: ANB0VdYz+f0IHlKXP0Ap99j4LQh1qXV+MOdrFo6rSpeMmcXQjeMPdbiuykjmX0o7Ndh5T2UEnIHFcg== X-Received: by 2002:a1c:c7c3:: with SMTP id x186-v6mr8763653wmf.109.1536441919498; Sat, 08 Sep 2018 14:25:19 -0700 (PDT) Received: from localhost.localdomain (62.83.35.8.dyn.user.ono.com. [62.83.35.8]) by smtp.gmail.com with ESMTPSA id u40-v6sm17340786wrc.43.2018.09.08.14.25.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Sep 2018 14:25:18 -0700 (PDT) From: Miguel Ojeda To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, Miguel Ojeda , Rasmus Villemoes , Luc Van Oostenryck , Eli Friedman , Christopher Li , Kees Cook , Ingo Molnar , Geert Uytterhoeven , Greg Kroah-Hartman , Masahiro Yamada , Joe Perches , Dominique Martinet , Nick Desaulniers , linux-sparse@vger.kernel.org Subject: [PATCH v4 06/13] Compiler Attributes: naked can be shared Date: Sat, 8 Sep 2018 23:24:52 +0200 Message-Id: <20180908212459.19736-7-miguel.ojeda.sandonis@gmail.com> In-Reply-To: <20180908212459.19736-1-miguel.ojeda.sandonis@gmail.com> References: <20180908212459.19736-1-miguel.ojeda.sandonis@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The naked attribute is supported by at least gcc >= 4.6 (for ARM, which is the only current user), gcc >= 8 (for x86), clang >= 3.1 and icc >= 13. See https://godbolt.org/z/350Dyc Therefore, move it out of compiler-gcc.h so that the definition is shared by all compilers. Cc: Rasmus Villemoes Cc: Luc Van Oostenryck Cc: Eli Friedman Cc: Christopher Li Cc: Kees Cook Cc: Ingo Molnar Cc: Geert Uytterhoeven Cc: Greg Kroah-Hartman Cc: Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Nick Desaulniers Cc: Linus Torvalds Cc: linux-sparse@vger.kernel.org Suggested-by: Arnd Bergmann Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 -------- include/linux/compiler_types.h | 8 ++++++++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 4cd5e9264bce..3b32bbfa5a49 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -72,14 +72,6 @@ #define __noretpoline __attribute__((__indirect_branch__("keep"))) #endif -/* - * it doesn't make sense on ARM (currently the only user of __naked) - * to trace naked functions because then mcount is called without - * stack and frame pointer being set up and there is no chance to - * restore the lr register to the value before mcount was called. - */ -#define __naked __attribute__((__naked__)) notrace - #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) #define __compiletime_object_size(obj) __builtin_object_size(obj, 0) diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index 83475515bc39..5ff9cda893f4 100644 --- a/include/linux/compiler_types.h +++ b/include/linux/compiler_types.h @@ -224,6 +224,14 @@ struct ftrace_likely_data { #define notrace __attribute__((__no_instrument_function__)) #endif +/* + * it doesn't make sense on ARM (currently the only user of __naked) + * to trace naked functions because then mcount is called without + * stack and frame pointer being set up and there is no chance to + * restore the lr register to the value before mcount was called. + */ +#define __naked __attribute__((__naked__)) notrace + #define __compiler_offsetof(a, b) __builtin_offsetof(a, b) /* -- 2.17.1