From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B30BCC04ABB for ; Tue, 11 Sep 2018 17:53:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4538E206B8 for ; Tue, 11 Sep 2018 17:53:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4538E206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728164AbeIKWxq (ORCPT ); Tue, 11 Sep 2018 18:53:46 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57616 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726782AbeIKWxq (ORCPT ); Tue, 11 Sep 2018 18:53:46 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fzmqd-0001nk-Oz; Tue, 11 Sep 2018 17:53:11 +0000 From: Colin King To: Florian Fainelli , Andrew Lunn , Vivien Didelot , "David S . Miller" , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][net-dsa-next] net: dsa: b53: ensure variable pause is initialized Date: Tue, 11 Sep 2018 18:53:11 +0100 Message-Id: <20180911175311.17929-1-colin.king@canonical.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Currenly integer pause is not initialized and may be left an uninitialized state if flow control on BCM5301x's CPU port is not enabled. This will potentially feed garbage into the TX or RX pause bits that are or'd into pause. Fix this by ensuring pause is initialized to zero. Detected by static analysis with smatch: "error: uninitialized symbol 'pause'." Fixes: 5e004460f874 ("net: dsa: b53: Add helper to set link parameters") Signed-off-by: Colin Ian King --- drivers/net/dsa/b53/b53_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index ea4256cd628b..dbf5b86a07fe 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1025,7 +1025,7 @@ static void b53_adjust_link(struct dsa_switch *ds, int port, struct b53_device *dev = ds->priv; struct ethtool_eee *p = &dev->ports[port].eee; u8 rgmii_ctrl = 0, reg = 0, off; - int pause; + int pause = 0; if (!phy_is_pseudo_fixed_link(phydev)) return; -- 2.17.1