From: John Whitmore <johnfwhitmore@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 20/20] staging:rtl8192u: Rename OWN - Style
Date: Tue, 11 Sep 2018 22:49:56 +0100 [thread overview]
Message-ID: <20180911214955.GE31239@xux707-tw> (raw)
In-Reply-To: <20180910150927.GC25530@kroah.com>
On Mon, Sep 10, 2018 at 05:09:27PM +0200, Greg KH wrote:
> On Sat, Sep 01, 2018 at 12:02:50AM +0100, John Whitmore wrote:
> > Rename the member variable 'OWN' to 'own', this is to comply with the
> > coding standard, where variables are named in lowercase.
> >
> > This is a simple coding style change which should have no impact on
> > runtime code execution.
> >
> > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> > ---
> > drivers/staging/rtl8192u/r8192U.h | 2 +-
> > drivers/staging/rtl8192u/r8192U_core.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
> > index 68e82b32a88e..f963b664e221 100644
> > --- a/drivers/staging/rtl8192u/r8192U.h
> > +++ b/drivers/staging/rtl8192u/r8192U.h
> > @@ -165,7 +165,7 @@ struct tx_desc_819x_usb {
> > u8 last_seg:1;
> > u8 first_seg:1;
> > u8 linip:1;
> > - u8 OWN:1;
> > + u8 own:1;
> >
> > /* DWORD 1 */
> > u8 TxFWInfoSize;
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> > index 911d0214b48a..4d0f70ec31ac 100644
> > --- a/drivers/staging/rtl8192u/r8192U_core.c
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -1558,7 +1558,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)
> > /* DWORD 0 */
> > tx_desc->first_seg = 1;
> > tx_desc->last_seg = 1;
> > - tx_desc->OWN = 1;
> > + tx_desc->own = 1;
>
> Is this another case of a variable being set once and then never used?
>
> If so, just delete it.
>
> thanks,
>
> greg k-h
em, I wasn't sure because that variable's a memeber of the sk_buff * passed
into the funtion. That function should be static to the file and is only
called from function rtl8192_hard_start_xmit() but that's a function
pointer which is sort of exported:
priv->ieee80211->softmac_hard_start_xmit = rtl8192_hard_start_xmit;
Having said that the 'OWN' member is part of the private data:
struct tx_desc_819x_usb *tx_desc = (struct tx_desc_819x_usb *)skb->data;
Like I say I wasn't sure so played it safe. I guess it's private data so nobody
outside the driver should be messing with that data, and I'm not sure how
public that function is.
I'll read some, ponder a bit and have another go.
jwhitmore
prev parent reply other threads:[~2018-09-11 21:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 23:02 [PATCH 00/20] staging:rtl8192u: r8192U.h cleanup " John Whitmore
2018-08-31 23:02 ` [PATCH 01/20] staging:rtl8192u: Remove write_cam() " John Whitmore
2018-08-31 23:02 ` [PATCH 02/20] staging:rtl8192u: Remove read_cam() " John Whitmore
2018-08-31 23:02 ` [PATCH 03/20] staging:rtl8192u: Remove unused functions " John Whitmore
2018-08-31 23:02 ` [PATCH 04/20] staging:rtl8192u: Add SPDX-License-Identifier " John Whitmore
2018-08-31 23:02 ` [PATCH 05/20] staging:rtl8192u: Rename RTL819xU_MODULE_NAME " John Whitmore
2018-08-31 23:02 ` [PATCH 06/20] staging:rtl8192u: Rename Rx_Smooth_Factor " John Whitmore
2018-08-31 23:02 ` [PATCH 07/20] staging:rtl8192u: Refactor RT_TRACE " John Whitmore
2018-08-31 23:02 ` [PATCH 08/20] staging:rtl8192u: Fix space characters " John Whitmore
2018-08-31 23:02 ` [PATCH 09/20] staging:rtl8192u: Remove RT_DEBUG_DATA " John Whitmore
2018-08-31 23:02 ` [PATCH 10/20] staging:rtl8192u: Rename PHY_Beacon_RSSI_SLID_WIN_MAX " John Whitmore
2018-08-31 23:02 ` [PATCH 11/20] staging:rtl8192u: Rename OFDM_Table_Length " John Whitmore
2018-08-31 23:02 ` [PATCH 12/20] staging:rtl8192u: Rename CCK_Table_length " John Whitmore
2018-08-31 23:02 ` [PATCH 13/20] staging:rtl8192u: Rename PktSize Style John Whitmore
2018-08-31 23:02 ` [PATCH 14/20] staging:rtl8192u: Rename Offset - Style John Whitmore
2018-08-31 23:02 ` [PATCH 15/20] staging:rtl8192u: Rename Reserved... structure members " John Whitmore
2018-08-31 23:02 ` [PATCH 16/20] staging:rtl8192u: Rename CmdInit " John Whitmore
2018-08-31 23:02 ` [PATCH 17/20] staging:rtl8192u: Rename LastSeg " John Whitmore
2018-08-31 23:02 ` [PATCH 18/20] staging:rtl8192u: Rename FirstSeg " John Whitmore
2018-09-10 15:10 ` Greg KH
2018-08-31 23:02 ` [PATCH 19/20] staging:rtl8192u: Rename LINIP " John Whitmore
2018-09-10 15:09 ` Greg KH
2018-08-31 23:02 ` [PATCH 20/20] staging:rtl8192u: Rename OWN " John Whitmore
2018-09-10 15:09 ` Greg KH
2018-09-11 21:49 ` John Whitmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911214955.GE31239@xux707-tw \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®