From: Steven Rostedt <rostedt@goodmis.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Kunxun Xie <xiekunxun@huawei.com>
Subject: Re: [Question] Are the trace APIs declared by "TRACE_EVENT(irq_handler_entry" allowed to be used in Ko?
Date: Tue, 11 Sep 2018 23:54:45 -0400 [thread overview]
Message-ID: <20180911235445.3f361575@vmware.local.home> (raw)
In-Reply-To: <5B987525.9070300@huawei.com>
On Wed, 12 Sep 2018 10:08:37 +0800
"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> wrote:
> After patch 7e066fb870fc ("tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()"),
> the trace APIs declared by "TRACE_EVENT(irq_handler_entry" can not be directly used
> by ko, because it's not explicitly exported by EXPORT_TRACEPOINT_SYMBOL_GPL or
> EXPORT_TRACEPOINT_SYMBOL.
>
> Did we miss it? or it's not recommended to be used in ko?
>
Why do you need it. This patch is almost 10 years old, and you are just
now finding an issue with it?
-- Steve
>
> -------------
>
> commit 7e066fb870fcd1025ec3ba7bbde5d541094f4ce1
> Author: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> Date: Fri Nov 14 17:47:47 2008 -0500
>
> tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()
>
> Impact: API *CHANGE*. Must update all tracepoint users.
>
> Add DEFINE_TRACE() to tracepoints to let them declare the tracepoint
> structure in a single spot for all the kernel. It helps reducing memory
> consumption, especially when declaring a lot of tracepoints, e.g. for
> kmalloc tracing.
>
> *API CHANGE WARNING*: now, DECLARE_TRACE() must be used in headers for
> tracepoint declarations rather than DEFINE_TRACE(). This is the sane way
> to do it. The name previously used was misleading.
>
> Updates scheduler instrumentation to follow this API change.
>
>
prev parent reply other threads:[~2018-09-12 3:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 2:08 Leizhen (ThunderTown)
2018-09-12 3:54 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911235445.3f361575@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@redhat.com \
--cc=thunder.leizhen@huawei.com \
--cc=xiekunxun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome