From: Jason Yan <yanaijie@huawei.com>
To: <martin.petersen@oracle.com>, <jejb@linux.vnet.ibm.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<john.garry@huawei.com>, <zhaohongjiang@huawei.com>,
<hare@suse.com>, <dan.j.williams@intel.com>, <jthumshirn@suse.de>,
<hch@lst.de>, <huangdaode@hisilicon.com>,
<chenxiang66@hisilicon.com>, <miaoxie@huawei.com>,
Jason Yan <yanaijie@huawei.com>, Ewan Milne <emilne@redhat.com>,
Tomas Henzl <thenzl@redhat.com>
Subject: [PATCH 4/5] scsi: libsas: check the ata device status by ata_dev_enabled()
Date: Wed, 12 Sep 2018 16:29:45 +0800 [thread overview]
Message-ID: <20180912082946.34814-5-yanaijie@huawei.com> (raw)
In-Reply-To: <20180912082946.34814-1-yanaijie@huawei.com>
When ata device IDENTIFY failed, the ata device status is
ATA_DEV_UNKNOWN. The libata reported like:
[113518.620433] ata5.00: qc timeout (cmd 0xec)
[113518.653646] ata5.00: failed to IDENTIFY (I/O error, err_mask=0x4)
But libsas verifies the device status by ata_dev_disabled(), which
skiped ATA_DEV_UNKNOWN. This will make libsas think the ata device
probing succeed the device cannot be actually brought up. And even the
new bcast of this device will be considered as flutter and will not
probe this device again.
Change ata_dev_disabled() to !ata_dev_enabled() so that libsas can
deal with this if the ata device probe failed. New bcasts can let us
try to probe the device again and bring it up if it is fine to
IDENTIFY.
Tested-by: Zhou Yupeng <zhouyupeng1@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
CC: John Garry <john.garry@huawei.com>
CC: Johannes Thumshirn <jthumshirn@suse.de>
CC: Ewan Milne <emilne@redhat.com>
CC: Christoph Hellwig <hch@lst.de>
CC: Tomas Henzl <thenzl@redhat.com>
CC: Dan Williams <dan.j.williams@intel.com>
CC: Hannes Reinecke <hare@suse.com>
---
drivers/scsi/libsas/sas_ata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 64a958a99f6a..4f6cdf53e913 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -654,7 +654,7 @@ void sas_probe_sata(struct asd_sas_port *port)
/* if libata could not bring the link up, don't surface
* the device
*/
- if (ata_dev_disabled(sas_to_ata_dev(dev)))
+ if (!ata_dev_enabled(sas_to_ata_dev(dev)))
sas_fail_probe(dev, __func__, -ENODEV);
}
--
2.14.4
next prev parent reply other threads:[~2018-09-12 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 8:29 [PATCH 0/5] scsi: libsas: some code cleanups and bug fixes Jason Yan
2018-09-12 8:29 ` [PATCH 1/5] scsi: libsas: delete dead code in scsi_transport_sas.c Jason Yan
2018-09-17 8:35 ` John Garry
2018-09-17 13:53 ` Hannes Reinecke
2018-09-12 8:29 ` [PATCH 2/5] scsi: libsas: check the lldd callback correctly Jason Yan
2018-09-17 8:11 ` John Garry
2018-09-17 13:54 ` Hannes Reinecke
2018-09-12 8:29 ` [PATCH 3/5] scsi: libsas: always unregister the old device if going to discover new Jason Yan
2018-09-17 13:55 ` Hannes Reinecke
2018-09-12 8:29 ` Jason Yan [this message]
2018-09-17 13:56 ` [PATCH 4/5] scsi: libsas: check the ata device status by ata_dev_enabled() Hannes Reinecke
2018-09-18 13:54 ` John Garry
2018-09-19 2:54 ` Jason Yan
2018-09-12 8:29 ` [PATCH 5/5] scsi: libsas: fix a race condition when smp task timeout Jason Yan
2018-09-17 9:47 ` John Garry
2018-09-19 2:49 ` Jason Yan
2018-09-19 8:39 ` John Garry
2018-09-17 13:57 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912082946.34814-5-yanaijie@huawei.com \
--to=yanaijie@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=dan.j.williams@intel.com \
--cc=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=huangdaode@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miaoxie@huawei.com \
--cc=thenzl@redhat.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®