From: Bjorn Helgaas <helgaas@kernel.org>
To: Joshua Abraham <j.abraham1776@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers: pci: remove set but unused variable
Date: Wed, 12 Sep 2018 07:11:37 -0500 [thread overview]
Message-ID: <20180912121137.GE118330@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180912023908.GA5549@josh-ThinkPad-T460s>
On Tue, Sep 11, 2018 at 04:39:08PM -1000, Joshua Abraham wrote:
> This patch removes a set but unused variable in quirks.c.
>
> Fixes warning:
> variable ‘mmio_sys_info’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
Applied to pci/misc for v4.20, thanks!
> ---
> drivers/pci/quirks.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index ef7143a274e0..690a3b71aa1f 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4993,7 +4993,6 @@ static void quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)
> void __iomem *mmio;
> struct ntb_info_regs __iomem *mmio_ntb;
> struct ntb_ctrl_regs __iomem *mmio_ctrl;
> - struct sys_info_regs __iomem *mmio_sys_info;
> u64 partition_map;
> u8 partition;
> int pp;
> @@ -5014,7 +5013,6 @@ static void quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)
>
> mmio_ntb = mmio + SWITCHTEC_GAS_NTB_OFFSET;
> mmio_ctrl = (void __iomem *) mmio_ntb + SWITCHTEC_NTB_REG_CTRL_OFFSET;
> - mmio_sys_info = mmio + SWITCHTEC_GAS_SYS_INFO_OFFSET;
>
> partition = ioread8(&mmio_ntb->partition_id);
>
> --
> 2.17.1
>
prev parent reply other threads:[~2018-09-12 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 2:39 Joshua Abraham
2018-09-12 12:11 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912121137.GE118330@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=j.abraham1776@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®