From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Robert Węcławski" <r.weclawski@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
"Kees Cook" <keescook@chromium.org>,
"Kacper Kołodziej" <kacper@kolodziej.it>,
"Mihaela Muraru" <mihaela.muraru21@gmail.com>,
"Valentine Sinitsyn" <valentine.sinitsyn@gmail.com>,
linux-kernel@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Janani Sankara Babu" <jananis37@gmail.com>,
"Colin Ian King" <colin.king@canonical.com>,
"Santha Meena Ramamoorthy" <santhameena13@gmail.com>
Subject: Re: [PATCH] staging: rtl8188eu: remove code that is valid only for 5 GHz
Date: Fri, 14 Sep 2018 09:12:32 +0300 [thread overview]
Message-ID: <20180914061232.323jxklcp75ugtvr@mwanda> (raw)
In-Reply-To: <20180913203246.4376-1-r.weclawski@gmail.com>
On Thu, Sep 13, 2018 at 10:32:39PM +0200, Robert Węcławski wrote:
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index eca06f05c0c4..b610443f2ac6 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> @@ -1819,16 +1819,6 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
> case WIRELESS_11BG_24N:
> pdev_network->NetworkTypeInUse = Ndis802_11OFDM24;
> break;
> - case WIRELESS_11A:
> - case WIRELESS_11A_5N:
> - pdev_network->NetworkTypeInUse = Ndis802_11OFDM5;
> - break;
> - case WIRELESS_11ABGN:
> - if (pregistrypriv->channel > 14)
> - pdev_network->NetworkTypeInUse = Ndis802_11OFDM5;
> - else
> - pdev_network->NetworkTypeInUse = Ndis802_11OFDM24;
> - break;
> default:
> /* TODO */
> break;
Are you sure about this chunk? I would have thought that <= 14 was not
5G. (I try to avoid rhetorical questions and I don't know the answer
here).
regards,
dan carpenter
next prev parent reply other threads:[~2018-09-14 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 20:32 Robert Węcławski
2018-09-14 6:12 ` Dan Carpenter [this message]
2018-09-14 15:58 ` Robert Węcławski
2018-09-14 16:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914061232.323jxklcp75ugtvr@mwanda \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jananis37@gmail.com \
--cc=kacper@kolodziej.it \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihaela.muraru21@gmail.com \
--cc=r.weclawski@gmail.com \
--cc=santhameena13@gmail.com \
--cc=valentine.sinitsyn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®