From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIM_INVALID,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902DDECE562 for ; Sun, 16 Sep 2018 01:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4799E21470 for ; Sun, 16 Sep 2018 01:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=thunk.org header.i=@thunk.org header.b="NBVJsb9Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4799E21470 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727668AbeIPGxt (ORCPT ); Sun, 16 Sep 2018 02:53:49 -0400 Received: from imap.thunk.org ([74.207.234.97]:37010 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbeIPGxs (ORCPT ); Sun, 16 Sep 2018 02:53:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FYR5+faLS1P/SYG5nJyaWzRxSBh9weLOYAYN41YDGyY=; b=NBVJsb9ZQtvKjvyHld78qXqYHB B/67xJH0Cwus7h7e9acqkFqe1ZVMzzwGjtxzgN26lOMPTYnlbmAQmXB5bseqOQyLJqo91dKqwBLab 92m6A1ZgiDtiy2OPLTXq3jEMZZqfScCLxmMwQwFslM0NDAJgbJDRENJLDLf5VA6iDuZw=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1g1LvN-0005jv-18; Sun, 16 Sep 2018 01:32:33 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 7375C7A585B; Sat, 15 Sep 2018 21:32:31 -0400 (EDT) Date: Sat, 15 Sep 2018 21:32:31 -0400 From: "Theodore Y. Ts'o" To: Toshi Kani Cc: jack@suse.cz, dan.j.williams@intel.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/3] ext4, dax: add ext4_bmap to ext4_dax_aops Message-ID: <20180916013231.GD8652@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Toshi Kani , jack@suse.cz, dan.j.williams@intel.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20180914145114.11122-1-toshi.kani@hpe.com> <20180914145114.11122-2-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180914145114.11122-2-toshi.kani@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2018 at 08:51:12AM -0600, Toshi Kani wrote: > Ext4 mount path calls .bmap to the journal inode. This currently > works for the DAX mount case because ext4_iget() always set > 'ext4_da_aops' to any regular files. > > In preparation to fix ext4_iget() to set 'ext4_dax_aops' for ext4 > DAX files, add ext4_bmap() to 'ext4_dax_aops'. .bmap works for > DAX inodes. [1] > > [1]: https://lkml.org/lkml/2018/9/12/803 > Fixes: 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops") > Signed-off-by: Toshi Kani > Suggested-by: Jan Kara > Cc: Jan Kara > Cc: Dan Williams > Cc: "Theodore Ts'o" > Cc: Andreas Dilger > Cc: Thanks, applied. - Ted