mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-crypto@vger.kernel.org,
	davem@davemloft.net, gregkh@linuxfoundation.org,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH net-next v4 20/20] net: WireGuard secure network tunnel
Date: Sun, 16 Sep 2018 07:01:47 +0800	[thread overview]
Message-ID: <201809160701.EQDrNg4f%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180914162240.7925-21-Jason@zx2c4.com>

[-- Attachment #1: Type: text/plain, Size: 3298 bytes --]

Hi Jason,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/WireGuard-Secure-Network-Tunnel/20180916-043623
config: x86_64-randconfig-b0-09160521 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from lib/zinc/curve25519/curve25519.c:45:0:
   lib/zinc/curve25519/curve25519-hacl64.h: In function 'curve25519_generic':
>> lib/zinc/curve25519/curve25519-hacl64.h:785:1: warning: the frame size of 13216 bytes is larger than 8192 bytes [-Wframe-larger-than=]
    }
    ^

vim +785 lib/zinc/curve25519/curve25519-hacl64.h

cec5aa7c Jason A. Donenfeld 2018-09-14  755  
cec5aa7c Jason A. Donenfeld 2018-09-14  756  static void curve25519_generic(u8 mypublic[CURVE25519_POINT_SIZE],
cec5aa7c Jason A. Donenfeld 2018-09-14  757  			       const u8 secret[CURVE25519_POINT_SIZE],
cec5aa7c Jason A. Donenfeld 2018-09-14  758  			       const u8 basepoint[CURVE25519_POINT_SIZE])
cec5aa7c Jason A. Donenfeld 2018-09-14  759  {
cec5aa7c Jason A. Donenfeld 2018-09-14  760  	u64 buf0[10] __aligned(32) = { 0 };
cec5aa7c Jason A. Donenfeld 2018-09-14  761  	u64 *x0 = buf0;
cec5aa7c Jason A. Donenfeld 2018-09-14  762  	u64 *z = buf0 + 5;
cec5aa7c Jason A. Donenfeld 2018-09-14  763  	u64 *q;
cec5aa7c Jason A. Donenfeld 2018-09-14  764  	format_fexpand(x0, basepoint);
cec5aa7c Jason A. Donenfeld 2018-09-14  765  	z[0] = 1;
cec5aa7c Jason A. Donenfeld 2018-09-14  766  	q = buf0;
cec5aa7c Jason A. Donenfeld 2018-09-14  767  	{
cec5aa7c Jason A. Donenfeld 2018-09-14  768  		u8 e[32] __aligned(32) = { 0 };
cec5aa7c Jason A. Donenfeld 2018-09-14  769  		u8 *scalar;
cec5aa7c Jason A. Donenfeld 2018-09-14  770  		memcpy(e, secret, 32);
cec5aa7c Jason A. Donenfeld 2018-09-14  771  		normalize_secret(e);
cec5aa7c Jason A. Donenfeld 2018-09-14  772  		scalar = e;
cec5aa7c Jason A. Donenfeld 2018-09-14  773  		{
cec5aa7c Jason A. Donenfeld 2018-09-14  774  			u64 buf[15] = { 0 };
cec5aa7c Jason A. Donenfeld 2018-09-14  775  			u64 *nq = buf;
cec5aa7c Jason A. Donenfeld 2018-09-14  776  			u64 *x = nq;
cec5aa7c Jason A. Donenfeld 2018-09-14  777  			x[0] = 1;
cec5aa7c Jason A. Donenfeld 2018-09-14  778  			ladder_cmult(nq, scalar, q);
cec5aa7c Jason A. Donenfeld 2018-09-14  779  			format_scalar_of_point(mypublic, nq);
cec5aa7c Jason A. Donenfeld 2018-09-14  780  			memzero_explicit(buf, sizeof(buf));
cec5aa7c Jason A. Donenfeld 2018-09-14  781  		}
cec5aa7c Jason A. Donenfeld 2018-09-14  782  		memzero_explicit(e, sizeof(e));
cec5aa7c Jason A. Donenfeld 2018-09-14  783  	}
cec5aa7c Jason A. Donenfeld 2018-09-14  784  	memzero_explicit(buf0, sizeof(buf0));
cec5aa7c Jason A. Donenfeld 2018-09-14 @785  }

:::::: The code at line 785 was first introduced by commit
:::::: cec5aa7cd396d909f8555d2df80d3e1a0f94688b zinc: Curve25519 generic C implementations and selftest

:::::: TO: Jason A. Donenfeld <Jason@zx2c4.com>
:::::: CC: 0day robot <lkp@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30997 bytes --]

  parent reply	other threads:[~2018-09-15 23:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14 16:22 [PATCH net-next v4 00/20] WireGuard: Secure Network Tunnel Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 01/20] asm: simd context helper API Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 02/20] zinc: introduce minimal cryptography library Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 03/20] zinc: ChaCha20 generic C implementation Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 04/20] zinc: ChaCha20 ARM and ARM64 implementations Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 05/20] zinc: ChaCha20 x86_64 implementation Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 06/20] zinc: ChaCha20 MIPS32r2 implementation Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 07/20] zinc: Poly1305 generic C implementations and selftest Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 08/20] zinc: Poly1305 ARM and ARM64 implementations Jason A. Donenfeld
2018-09-14 17:27   ` Ard Biesheuvel
2018-09-14 17:45     ` Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 09/20] zinc: Poly1305 x86_64 implementation Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 10/20] zinc: Poly1305 MIPS32r2 and MIPS64 implementations Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 11/20] zinc: ChaCha20Poly1305 construction and selftest Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 12/20] zinc: BLAKE2s generic C implementation " Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 13/20] zinc: BLAKE2s x86_64 implementation Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 14/20] zinc: Curve25519 generic C implementations and selftest Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 15/20] zinc: Curve25519 ARM implementation Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 16/20] zinc: Curve25519 x86_64 implementation Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 17/20] crypto: port Poly1305 to Zinc Jason A. Donenfeld
2018-09-15 23:02   ` kbuild test robot
2018-09-16  0:31     ` Jason A. Donenfeld
2018-09-15 23:39   ` kbuild test robot
2018-09-14 16:22 ` [PATCH net-next v4 18/20] crypto: port ChaCha20 " Jason A. Donenfeld
2018-09-14 17:38   ` Ard Biesheuvel
2018-09-14 17:49     ` Jason A. Donenfeld
     [not found]   ` <201809160711.HzjdJedZ%fengguang.wu@intel.com>
2018-09-15 23:21     ` Jason A. Donenfeld
2018-09-16 19:51   ` Martin Willi
2018-09-17  4:54     ` Jason A. Donenfeld
2018-09-17 11:35   ` kbuild test robot
2018-09-14 16:22 ` [PATCH net-next v4 19/20] security/keys: rewrite big_key crypto to use Zinc Jason A. Donenfeld
2018-09-15 23:52   ` kbuild test robot
2018-09-16  0:29     ` Jason A. Donenfeld
2018-09-14 16:22 ` [PATCH net-next v4 20/20] net: WireGuard secure network tunnel Jason A. Donenfeld
2018-09-15 22:17   ` kbuild test robot
2018-09-15 23:14     ` Jason A. Donenfeld
2018-09-15 23:01   ` kbuild test robot [this message]
2018-09-15 23:48     ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201809160701.EQDrNg4f%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=Jason@zx2c4.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®