From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0333ECE560 for ; Mon, 17 Sep 2018 15:09:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E476214C2 for ; Mon, 17 Sep 2018 15:09:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E476214C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729099AbeIQUhb (ORCPT ); Mon, 17 Sep 2018 16:37:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45998 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728437AbeIQUhb (ORCPT ); Mon, 17 Sep 2018 16:37:31 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 23125144B232F; Mon, 17 Sep 2018 08:09:46 -0700 (PDT) Date: Mon, 17 Sep 2018 08:09:45 -0700 (PDT) Message-Id: <20180917.080945.1667529660601929619.davem@davemloft.net> To: yuehaibing@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dev@openvswitch.org Subject: Re: [PATCH net-next] net: fix return type of ndo_start_xmit function From: David Miller In-Reply-To: <20180915081906.23816-1-yuehaibing@huawei.com> References: <20180915081906.23816-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Sep 2018 08:09:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please don't do this. The hard part of fixing this is not what you are doing, changing the return type. The hard part is fixing each and every function to actually return values which are members of the netdev_tx_t enumeration. Please fix each and every function properly. Thank you.