From: David Miller <davem@davemloft.net>
To: ahs3@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
isubramanian@apm.com, kchudgar@apm.com, qnguyen@apm.com
Subject: Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage
Date: Mon, 17 Sep 2018 19:35:31 -0700 (PDT) [thread overview]
Message-ID: <20180917.193531.1424852853827678152.davem@davemloft.net> (raw)
In-Reply-To: <20180917233533.28626-1-ahs3@redhat.com>
From: Al Stone <ahs3@redhat.com>
Date: Mon, 17 Sep 2018 17:35:33 -0600
> @@ -866,8 +866,11 @@ static int xgene_enet_napi(struct napi_struct *napi, const int budget)
> processed = xgene_enet_process_ring(ring, budget);
>
> if (processed != budget) {
> + struct irq_desc *desc = irq_to_desc(ring->irq);
> +
> napi_complete_done(napi, processed);
> - enable_irq(ring->irq);
> + if (desc && desc->depth > 0)
> + enable_irq(ring->irq);
I really can't accept a patch that grovels into IRQ layer internals
to work around a driver's IRQ enable/disable usage problem.
Sorry.
next prev parent reply other threads:[~2018-09-18 2:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 23:35 Al Stone
2018-09-18 2:35 ` David Miller [this message]
2018-09-18 20:21 ` Al Stone
2018-09-18 23:09 ` Lendacky, Thomas
2018-09-18 23:15 ` Al Stone
2018-09-18 23:21 ` Florian Fainelli
2018-09-18 23:27 ` Eric Dumazet
2018-09-18 23:56 ` Eric Dumazet
2018-09-19 0:03 ` Florian Fainelli
2018-09-19 2:32 ` Eric Dumazet
2018-09-18 23:25 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917.193531.1424852853827678152.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ahs3@redhat.com \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qnguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®