From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA64ECE563 for ; Mon, 17 Sep 2018 09:24:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E03ED214AB for ; Mon, 17 Sep 2018 09:24:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E03ED214AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbeIQOvF (ORCPT ); Mon, 17 Sep 2018 10:51:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44586 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726824AbeIQOvF (ORCPT ); Mon, 17 Sep 2018 10:51:05 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 0D8DDBE0; Mon, 17 Sep 2018 09:24:31 +0000 (UTC) Date: Mon, 17 Sep 2018 11:24:29 +0200 From: Greg KH To: zhong jiang Cc: georgi.djakov@linaro.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] interconnect: Fix a GCC compiler warning Message-ID: <20180917092429.GB25662@kroah.com> References: <1537108310-2086-1-git-send-email-zhongjiang@huawei.com> <5B9F6B8B.7020100@huawei.com> <20180917085954.GA23740@kroah.com> <5B9F7196.1070203@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B9F7196.1070203@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2018 at 05:19:18PM +0800, zhong jiang wrote: > On 2018/9/17 16:59, Greg KH wrote: > > On Mon, Sep 17, 2018 at 04:53:31PM +0800, zhong jiang wrote: > >> +to Greg and Andrew. > >> > >> On 2018/9/16 22:31, zhong jiang wrote: > >>> Fix the following compile warning: > >>> > >>> drivers/interconnect/core.c:26:23: warning: 'icc_debugfs_dir' defined but not used [-Wunused-variable] > >>> static struct dentry *icc_debugfs_dir; > >>> > >>> Signed-off-by: zhong jiang > >>> --- > >>> drivers/interconnect/core.c | 3 +++ > > This file is not in a released tree, where are you seeing it? > I see it in linux-next. Then please contact the owner of the branch where it came from. They are the only ones that can handle such a patch, not anyone else. > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > >>> index 2740f1a..9ea9959 100644 > >>> --- a/drivers/interconnect/core.c > >>> +++ b/drivers/interconnect/core.c > >>> @@ -23,7 +23,10 @@ > >>> static DEFINE_IDR(icc_idr); > >>> static LIST_HEAD(icc_provider_list); > >>> static DEFINE_MUTEX(icc_lock); > >>> + > >>> +#ifdef CONFIG_DEBUG_FS > >>> static struct dentry *icc_debugfs_dir; > >>> +#endif > > Why not move the variable to where it is used? It should be able to go > > under an existing #ifdef section, right? > Because the variable need to be used in __init and __exit. So it should be identified as > a gloabl variable. I fix it under the #ifdef condition. If the variable is being used this way, then the code is written incorrectly, such an #ifdef should not be needed for any debugfs calls/variables. thanks, greg k-h