mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Todd Poynor <toddpoynor@gmail.com>
To: Rob Springer <rspringer@google.com>,
	Ben Chan <benchan@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Nick Ewalt <nicholasewalt@google.com>,
	Todd Poynor <toddpoynor@google.com>
Subject: [PATCH 10/10] staging: gasket: page_table: handle failed dma_map_page
Date: Mon, 17 Sep 2018 05:39:05 -0700	[thread overview]
Message-ID: <20180917123905.213639-11-toddpoynor@gmail.com> (raw)
In-Reply-To: <20180917123905.213639-1-toddpoynor@gmail.com>

From: Nick Ewalt <nicholasewalt@google.com>

Handle dma_map_page failing in gasket_alloc_extended_subtable: free
memory, don't add invalid page table entry.

Signed-off-by: Nick Ewalt <nicholasewalt@google.com>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
---
 drivers/staging/gasket/gasket_page_table.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index 8364b49f147c2..964146f0df526 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -902,6 +902,17 @@ static int gasket_alloc_extended_subtable(struct gasket_page_table *pg_tbl,
 	/* Map the page into DMA space. */
 	pte->dma_addr = dma_map_page(pg_tbl->device, pte->page, 0, PAGE_SIZE,
 				     DMA_TO_DEVICE);
+	if (dma_mapping_error(pg_tbl->device, pte->dma_addr)) {
+		dev_dbg(pg_tbl->device,
+			"%s: fail to map page [pfn %lx phys %llx]\n",
+			__func__, page_to_pfn(pte->page),
+			page_to_phys(pte->page));
+
+		free_page(page_addr);
+		vfree(pte->sublevel);
+		memset(pte, 0, sizeof(struct gasket_page_table_entry));
+		return -ENOMEM;
+	}
 
 	/* make the addresses available to the device */
 	dma_addr = (pte->dma_addr + pte->offset) | GASKET_VALID_SLOT_FLAG;
-- 
2.19.0.397.gdd90340f6a-goog


      parent reply	other threads:[~2018-09-17 12:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 12:38 [PATCH 00/10] staging: gasket: Apex uncloaks, plus fixes Todd Poynor
2018-09-17 12:38 ` [PATCH 01/10] staging: gasket: Kconfig: describe Apex as an Edge TPU device Todd Poynor
2018-09-17 12:38 ` [PATCH 02/10] staging: gasket: interrupt: remove PCI-MSIX-specific status check Todd Poynor
2018-09-17 12:38 ` [PATCH 03/10] staging: gasket: page table: use GFP_KERNEL for dma_alloc_coherent Todd Poynor
2018-09-17 12:38 ` [PATCH 04/10] staging: gasket: fix DMA direction for extended page tables Todd Poynor
2018-09-17 12:39 ` [PATCH 05/10] staging: gasket: fix data page unmap DMA direction Todd Poynor
2018-09-17 12:39 ` [PATCH 06/10] staging: gasket: page_table: don't unmap coherent pages Todd Poynor
2018-09-17 12:39 ` [PATCH 07/10] staging: gasket: fix gasket_free_coherent_memory metadata frees Todd Poynor
2018-09-17 12:39 ` [PATCH 08/10] staging: gasket: cleanup if dma_map_page fails in gasket_perform_mapping Todd Poynor
2018-09-17 12:39 ` [PATCH 09/10] staging: gasket: page_table: use total_entries for max ext lvl0 page idx Todd Poynor
2018-09-17 12:39 ` Todd Poynor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180917123905.213639-11-toddpoynor@gmail.com \
    --to=toddpoynor@gmail.com \
    --cc=benchan@chromium.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicholasewalt@google.com \
    --cc=rspringer@google.com \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome