mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <helgaas@kernel.org>,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
	Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Subject: Re: [PATCH] PCI: iproc: Remove PAXC slot check to allow VF support
Date: Mon, 17 Sep 2018 16:01:17 +0100	[thread overview]
Message-ID: <20180917150117.GG7239@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20180828172258.76629-1-ray.jui@broadcom.com>

On Tue, Aug 28, 2018 at 10:22:58AM -0700, Ray Jui wrote:
> From: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
> 
> Fix previous incorrect logic that limits PAXC slot number to zero only.
> In order for SRIOV/VF to work, we need to allow the slot number to be
> greater than zero.
> 
> Fixes: 46560388c476c ("PCI: iproc: Allow multiple devices except on PAXC")
> Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
> ---
>  drivers/pci/controller/pcie-iproc.c | 8 --------
>  1 file changed, 8 deletions(-)

Applied to pci/iproc for v4.20, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index 3160e9342a2f..c20fd6bd68fd 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -630,14 +630,6 @@ static void __iomem *iproc_pcie_map_cfg_bus(struct iproc_pcie *pcie,
>  			return (pcie->base + offset);
>  	}
>  
> -	/*
> -	 * PAXC is connected to an internally emulated EP within the SoC.  It
> -	 * allows only one device.
> -	 */
> -	if (pcie->ep_is_internal)
> -		if (slot > 0)
> -			return NULL;
> -
>  	return iproc_pcie_map_ep_cfg_reg(pcie, busno, slot, fn, where);
>  }
>  
> -- 
> 2.17.1
> 

      reply	other threads:[~2018-09-17 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 17:22 Ray Jui
2018-09-17 15:01 ` Lorenzo Pieralisi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180917150117.GG7239@e107981-ln.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jitendra.bhivare@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ray.jui@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®