mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cedric Roux <sed@free.fr>
To: kgene@kernel.org, krzk@kernel.org, linux@armlinux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Cedric Roux <sed@free.fr>
Subject: [PATCH] ARM: s3c24xx: fix usage of pr_info/pr_cont
Date: Mon, 17 Sep 2018 22:43:50 +0200	[thread overview]
Message-ID: <20180917204350.15192-1-sed@free.fr> (raw)

This commit fixes the wrong usage of pr_info introduced by the
commit e728e4f20100 ("ARM: s3c24xx: formatting cleanup in
mach-mini2440.c").

Since the idea is to print on a single line, pr_cont has to be used.

Signed-off-by: Cedric Roux <sed@free.fr>
---
 arch/arm/mach-s3c24xx/mach-mini2440.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c
index 9f830abe701c..50d67d760efd 100644
--- a/arch/arm/mach-s3c24xx/mach-mini2440.c
+++ b/arch/arm/mach-s3c24xx/mach-mini2440.c
@@ -684,14 +684,14 @@ static void __init mini2440_init(void)
 		pr_info("MINI2440: LCD");
 		for (li = 0; li < ARRAY_SIZE(mini2440_lcd_cfg); li++)
 			if (li == features.lcd_index)
-				pr_info(" [%d:%dx%d]", li,
+				pr_cont(" [%d:%dx%d]", li,
 					mini2440_lcd_cfg[li].width,
 					mini2440_lcd_cfg[li].height);
 			else
-				pr_info(" %d:%dx%d", li,
+				pr_cont(" %d:%dx%d", li,
 					mini2440_lcd_cfg[li].width,
 					mini2440_lcd_cfg[li].height);
-		pr_info("\n");
+		pr_cont("\n");
 		s3c24xx_fb_set_platdata(&mini2440_fb_info);
 	}
 
-- 
2.18.0

Note: running: scripts/checkpatch.pl 000*
reports 3 warnings about the use of pr_cont.
Since this modification was required by Joe Perches, I think this patch
doest the correct thing.

             reply	other threads:[~2018-09-17 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 20:43 Cedric Roux [this message]
2018-09-19 17:11 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180917204350.15192-1-sed@free.fr \
    --to=sed@free.fr \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®