From: Mark Brown <broonie@kernel.org>
To: David Lechner <david@lechnology.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-spi <linux-spi@vger.kernel.org>,
linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] spi: spi-davinci: Add support for SPI_CS_WORD
Date: Mon, 17 Sep 2018 14:18:35 -0700 [thread overview]
Message-ID: <20180917211835.GH2471@sirena.org.uk> (raw)
In-Reply-To: <fb43f4d7-5b19-72be-9216-efdca9b59eba@lechnology.com>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On Thu, Sep 13, 2018 at 09:26:48AM -0500, David Lechner wrote:
> On 09/13/2018 08:44 AM, Geert Uytterhoeven wrote:
> I suppose it might be best to modify the SPI core to say:
> if ((spi->mode & SPI_CS_WORD) && (!(ctlr->mode_bits & SPI_CS_WORD) ||
> gpio_is_valid(spi->cs_gpio)) {
> instead of:
> if ((spi->mode & SPI_CS_WORD) && !(ctlr->mode_bits & SPI_CS_WORD)) {
> Then we could drop the error above.
Yes, that makes sense - the same thing is going to apply to any
controller with this support.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-17 21:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 0:39 [PATCH v2 0/4] spi: introduce SPI_CS_WORD mode flag David Lechner
2018-09-13 0:39 ` [PATCH v2 1/4] spi: add new SPI_CS_WORD flag David Lechner
2018-09-16 11:29 ` Jonathan Cameron
2018-09-13 0:39 ` [PATCH v2 2/4] spi: add software implementation for SPI_CS_WORD David Lechner
2018-09-16 11:32 ` Jonathan Cameron
2018-09-17 21:22 ` Applied "spi: add software implementation for SPI_CS_WORD" to the spi tree Mark Brown
2018-09-13 0:39 ` [PATCH v2 3/4] iio: adc: ti-ads7950: use SPI_CS_WORD to reduce CPU usage David Lechner
2018-09-16 11:41 ` Jonathan Cameron
2018-09-16 16:24 ` David Lechner
2018-09-17 8:33 ` Jonathan Cameron
2018-09-13 0:39 ` [PATCH v2 4/4] spi: spi-davinci: Add support for SPI_CS_WORD David Lechner
2018-09-13 13:44 ` Geert Uytterhoeven
2018-09-13 14:26 ` David Lechner
2018-09-17 21:18 ` Mark Brown [this message]
2018-09-17 21:17 ` [PATCH v2 0/4] spi: introduce SPI_CS_WORD mode flag Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917211835.GH2471@sirena.org.uk \
--to=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=geert@linux-m68k.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome