From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B45ECE564 for ; Tue, 18 Sep 2018 16:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4627F214C2 for ; Tue, 18 Sep 2018 16:35:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yfPNC3gX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4627F214C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730299AbeIRWIe (ORCPT ); Tue, 18 Sep 2018 18:08:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:32846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730029AbeIRWIe (ORCPT ); Tue, 18 Sep 2018 18:08:34 -0400 Received: from localhost (unknown [209.121.128.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51A14206B5; Tue, 18 Sep 2018 16:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1537288512; bh=m37A0+L9ewlyyLoAvfWE0dQrsjtriNOVFLnRTbpXqlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yfPNC3gXlU8HFi3AoHP58c/kt4OZ4XsdHjsglSAkFBOF2San6ZKJDOqy+O4igR81X TajL2bXhu/IAl9LF5uw9TT4zhDTkmmjZFo823nuoYzKEKRQmav7GSdFsgPSoGzikeG 4YK+OAAlQ3/NzKUZDglxAkUbqcTJ7GkLQzTRNq/4= Date: Tue, 18 Sep 2018 09:35:12 -0700 From: Vinod To: Manivannan Sadhasivam Cc: dan.j.williams@intel.com, afaerber@suse.de, robh+dt@kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org, dmaengine@vger.kernel.org, liuwei@actions-semi.com, 96boards@ucrobotics.com, devicetree@vger.kernel.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hzhang@ucrobotics.com, bdong@ucrobotics.com, manivannanece23@gmail.com, thomas.liau@actions-semi.com, jeff.chen@actions-semi.com, pn@denx.de, edgar.righi@lsitec.org.br Subject: Re: [PATCH 2/3] dmaengine: Add Slave and Cyclic mode support for Actions Semi Owl S900 SoC Message-ID: <20180918163512.GE2613@vkoul-mobl> References: <20180901164215.3683-1-manivannan.sadhasivam@linaro.org> <20180901164215.3683-3-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180901164215.3683-3-manivannan.sadhasivam@linaro.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-09-18, 22:12, Manivannan Sadhasivam wrote: > @@ -364,6 +372,26 @@ static inline int owl_dma_cfg_lli(struct owl_dma_vchan *vchan, > OWL_DMA_MODE_DT_DCU | OWL_DMA_MODE_SAM_INC | > OWL_DMA_MODE_DAM_INC; > > + break; > + case DMA_MEM_TO_DEV: > + mode |= OWL_DMA_MODE_TS(vchan->drq) > + | OWL_DMA_MODE_ST_DCU | OWL_DMA_MODE_DT_DEV > + | OWL_DMA_MODE_SAM_INC | OWL_DMA_MODE_DAM_CONST; > + > + /* Handle bus width for UART */ > + if (sconfig->dst_addr_width == DMA_SLAVE_BUSWIDTH_1_BYTE) > + mode |= OWL_DMA_MODE_NDDBW_8BIT; this is fine per se, but not correct way to handle in dmaengine driver. You should be agnostic to user of dmaengine, so handle all the buswidths the IP block supports and update the values accordingly. That way new uses can be added w/o requiring change in dmaengine driver -- ~Vinod