mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Gross <andy.gross@linaro.org>
To: zhong jiang <zhongjiang@huawei.com>
Cc: david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: Fix a uninitialized warning.
Date: Tue, 18 Sep 2018 10:17:07 -0700	[thread overview]
Message-ID: <20180918171707.GA6240@hector.localdomain> (raw)
In-Reply-To: <1537247208-33632-1-git-send-email-zhongjiang@huawei.com>

On Tue, Sep 18, 2018 at 01:06:48PM +0800, zhong jiang wrote:
> Fix the following compile warning:
> 
> drivers/soc/qcom/cmd-db.c:194:38: warning: ‘ent.addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return ret < 0 ? 0 : le32_to_cpu(ent.addr);
> 
> drivers/soc/qcom/cmd-db.c:247:38: warning: ‘ent.len’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return ret < 0 ? 0 : le16_to_cpu(ent.len);
> 
> drivers/soc/qcom/cmd-db.c:269:24: warning: ‘ent.addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   addr = le32_to_cpu(ent.addr);
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/soc/qcom/cmd-db.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

This is kind of an odd subject for the patch.  It should be something like
drivers: qcom: cmd-db: XXXXXXXXXXXXX

ASOC is sound related.


Regards,

Andy

  reply	other threads:[~2018-09-18 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18  5:06 zhong jiang
2018-09-18 17:17 ` Andy Gross [this message]
2018-09-19  1:52   ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180918171707.GA6240@hector.localdomain \
    --to=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®