From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4482AC433F4 for ; Tue, 18 Sep 2018 21:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECD0B21471 for ; Tue, 18 Sep 2018 21:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gliItWw5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECD0B21471 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730394AbeISC6Y (ORCPT ); Tue, 18 Sep 2018 22:58:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:59512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbeISC6Y (ORCPT ); Tue, 18 Sep 2018 22:58:24 -0400 Received: from localhost (unknown [213.57.183.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FD172133F; Tue, 18 Sep 2018 21:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1537305836; bh=aVa4FKcGtPgPkTqNr2XVe8P1w/CH+sADwQKyP+Trc50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gliItWw5HiEul/fqsmOm6mrZ/zaO3Ts+kznSjoy/pne1oPukjEUwna0T2ljhOHI4A G+yy0WKDk0xqvjyKrs/o3ux94UtYfFR3ZX+FP7iexbnVCa8r9m9arfwUNkP1uyrDn5 ospE7A0ARJtDhtUO+2QGT2bu3fqZr1is/Qu+SWsQ= Date: Wed, 19 Sep 2018 00:23:51 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Jan Dakinevich , Doug Ledford , Yishai Hadas , Parav Pandit , Mark Bloch , Daniel Jurgens , Kees Cook , Kamal Heib , Bart Van Assche , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Denis Lunev , Konstantin Khorenko Subject: Re: [PATCH 0/4] IB: decrease large contigous allocation Message-ID: <20180918212351.GB3661@mtr-leonro.mtl.com> References: <1537275826-27247-1-git-send-email-jan.dakinevich@virtuozzo.com> <20180918144623.GI11367@ziepe.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tDYGg60iReQ7u8wj" Content-Disposition: inline In-Reply-To: <20180918144623.GI11367@ziepe.ca> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tDYGg60iReQ7u8wj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 18, 2018 at 08:46:23AM -0600, Jason Gunthorpe wrote: > On Tue, Sep 18, 2018 at 04:03:42PM +0300, Jan Dakinevich wrote: > > The size of mlx4_ib_device became too large to be allocated as whole contigous > > block of memory. Currently it takes about 55K. On architecture with 4K page it > > means 3rd order. > > > > This patch series makes an attempt to split mlx4_ib_device into several parts > > and allocate them with less expensive kvzalloc > > Why split it up? Any reason not to just allocate the whole thing with > kvzalloc? And before we are rushing to dissect mlx4_ib driver, can you explain the rationale behind this change? The mlx4_ib driver represents high-performance device which needs enough memory resources to operate. Those devices are limited by number of PCIs and SRIOV VFs (upto 126) and very rare allocated/deallocated. I would like to see real rationale behind such change. Thanks > > Jason --tDYGg60iReQ7u8wj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJboWznAAoJEORje4g2clintC8QAJxerU0oMGgBbDR4HGzsEqz/ DfJ694zTNs+ol2zSjbTxRHljws2RJ5lExH9LErpMUtzIfFMnABwl2j+2qUmJbwnd lB2qSugb2BV6Pnd0TVoWJjklgdx2K37IIESYlNyaT0IYp5jucoAv1yd3c0rhfppu WF3d1pgn6ysDh1yypMojpk5O71S6q+Zb/ESzo9AAqKMSoppAKo6GU36T7W3hVbmm IyPBn+EogAmrPvEByIlLksMMJTbXnY5Lls5GR41kuLEI38VN/9occQC0iyMlGL8C WD+BQf4wIFFEtgpzToJmE7tEwgPZch6R2UNDJ/N56T/EItqgpKpni2BMkJsPJC8B 4TF8nLywq7i9XM4ygRHag6Fzs3dMAj+GXMLnLhk8Up+KiL3d87gZCpeMlMjYNByO 0QTJvdL50OOuzxFBRryunOWbKVqMoJlHJ95OhadGSXmT5o5zF5cws0GHW6oNGKy9 WMH1U48lQrtoYoq0+V6T+PFQ69odYVTQV0NYFWNzWvxrY6OsMahUuRSDjuF2N8W3 onop1dBfcok7fbR7cUkZi0bo8hwvu9Yin/pFjwn0p6pvSzkoiQnuIKqGjn4qJlVJ aytBCfS+WZul+n+Qcwst6Vlxa3EPix1GzuixIW0B74DYMZRz6IySs9+xBDOLKMMr HKRytq15Z3d8+kPWTS2B =g0eP -----END PGP SIGNATURE----- --tDYGg60iReQ7u8wj--