From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE093ECE564 for ; Tue, 18 Sep 2018 23:56:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 770D620C0E for ; Tue, 18 Sep 2018 23:56:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="cr4uKrLu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 770D620C0E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730772AbeISFbd (ORCPT ); Wed, 19 Sep 2018 01:31:33 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33258 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730532AbeISFbd (ORCPT ); Wed, 19 Sep 2018 01:31:33 -0400 Received: by mail-pf1-f196.google.com with SMTP id d4-v6so1779129pfn.0 for ; Tue, 18 Sep 2018 16:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gkBEWdFFgGgVIP/4LrH7Mpo1psKk37vPtRiqnNGSedg=; b=cr4uKrLu9tAUi15Vm0QwqxOUcEEDHoy3PI+QwVaXJyZmiT/Qp3BnccEyZUwjUyW83d W7jLo95gu8vI18mgA++X9C1k9mKTQQkdZiDq/oRZVDpkjM50HtemIlwYbMphGweP8GE5 l1kDHJjF1GdCg2nXJLeAcU8l1ctFVaJ/0gTck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gkBEWdFFgGgVIP/4LrH7Mpo1psKk37vPtRiqnNGSedg=; b=DVEh8vs0phKLSXVwp1vMxUlr1bNbzAMA3Tkevp369LfRrRIzR26eywamKfXZnYrBmk cEQT80ABxbIYlSOkNlmo2+n1x8Hhn2Lm3Niw5hm1G632Gum7dgdMvwUMWz0Wvv2gKcMQ GMKMYKL8XrMBNmNIv42D2PMOhev1HNylaQL8BsL6fP8Ct1BzIX4ck/h0gFp08wFayiYD UN0mbN9FDxs6zezbxk4kxCg6DN8BiEXaVOoV7tTj6973Zxc8UeFs5RqG1t5SVXulYCs/ yNBPUL6bFzn/VlgjGG6nHMKwaCXryKvs6EEWMeGjSxQcpNF7bmGxFI0uT7LcWJ7X5EVp S7dQ== X-Gm-Message-State: APzg51CAJU1M+d4YNu23VAPKxcoF8Njb9Xko6R/e1ZezzYoKMcqHDQ9n bHOc/aOL2vZZmVZTkifZSvlD X-Google-Smtp-Source: ANB0VdbRwRNJglDPOGiEm52k+Ik2TyGO4QgektlJkedue7zW/WKg97GvR7D1NShJtQ0hu6VgBiWn4g== X-Received: by 2002:a62:b604:: with SMTP id j4-v6mr32965304pff.199.1537314991559; Tue, 18 Sep 2018 16:56:31 -0700 (PDT) Received: from Mani-XPS-13-9360 ([209.121.128.187]) by smtp.gmail.com with ESMTPSA id f87-v6sm51021419pfh.168.2018.09.18.16.56.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 16:56:30 -0700 (PDT) Date: Tue, 18 Sep 2018 16:56:29 -0700 From: Manivannan Sadhasivam To: Vinod Cc: dan.j.williams@intel.com, afaerber@suse.de, robh+dt@kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org, dmaengine@vger.kernel.org, liuwei@actions-semi.com, 96boards@ucrobotics.com, devicetree@vger.kernel.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hzhang@ucrobotics.com, bdong@ucrobotics.com, manivannanece23@gmail.com, thomas.liau@actions-semi.com, jeff.chen@actions-semi.com, pn@denx.de, edgar.righi@lsitec.org.br Subject: Re: [PATCH 2/3] dmaengine: Add Slave and Cyclic mode support for Actions Semi Owl S900 SoC Message-ID: <20180918235629.GA20199@Mani-XPS-13-9360> References: <20180901164215.3683-1-manivannan.sadhasivam@linaro.org> <20180901164215.3683-3-manivannan.sadhasivam@linaro.org> <20180918163512.GE2613@vkoul-mobl> <20180918225236.GA17306@Mani-XPS-13-9360> <20180918233200.GK2613@vkoul-mobl> <20180918233414.GA19844@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180918233414.GA19844@Mani-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 04:34:14PM -0700, Manivannan Sadhasivam wrote: > On Tue, Sep 18, 2018 at 04:32:00PM -0700, Vinod wrote: > > Hi Mani, > > > > On 18-09-18, 15:52, Manivannan Sadhasivam wrote: > > > On Tue, Sep 18, 2018 at 09:35:12AM -0700, Vinod wrote: > > > > On 01-09-18, 22:12, Manivannan Sadhasivam wrote: > > > > > > > > > @@ -364,6 +372,26 @@ static inline int owl_dma_cfg_lli(struct owl_dma_vchan *vchan, > > > > > OWL_DMA_MODE_DT_DCU | OWL_DMA_MODE_SAM_INC | > > > > > OWL_DMA_MODE_DAM_INC; > > > > > > > > > > + break; > > > > > + case DMA_MEM_TO_DEV: > > > > > + mode |= OWL_DMA_MODE_TS(vchan->drq) > > > > > + | OWL_DMA_MODE_ST_DCU | OWL_DMA_MODE_DT_DEV > > > > > + | OWL_DMA_MODE_SAM_INC | OWL_DMA_MODE_DAM_CONST; > > > > > + > > > > > + /* Handle bus width for UART */ > > > > > + if (sconfig->dst_addr_width == DMA_SLAVE_BUSWIDTH_1_BYTE) > > > > > + mode |= OWL_DMA_MODE_NDDBW_8BIT; > > > > > > > > this is fine per se, but not correct way to handle in dmaengine driver. > > > > You should be agnostic to user of dmaengine, so handle all the buswidths > > > > the IP block supports and update the values accordingly. That way new > > > > uses can be added w/o requiring change in dmaengine driver > > > > > > Currently, all members of Owl family supports only 32bit and 8bit > > > bus widths. 32bit is common for all peripherals and 8bit applies to only > > > UART since the internal buffer is 8bit wide. So, this makes sense to me! > > > > Above you are onky handing DMA_SLAVE_BUSWIDTH_1_BYTE and not 32bit which > > this IP supports.. You should handle all widths supported vt hardware.. > > > > Hi Vinod, > > Default width is 32bit and we will only override it for UART... Should I > add a comment stating this? > I think it is better to select 32bit mode eventhough it is the default one. Will update it in next revision. Thanks, Mani > Thanks, > Mani > > > -- > > ~Vinod