From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13CDAC433F4 for ; Thu, 20 Sep 2018 04:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD29B20867 for ; Thu, 20 Sep 2018 04:15:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD29B20867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730654AbeITJ4h (ORCPT ); Thu, 20 Sep 2018 05:56:37 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34238 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbeITJ4h (ORCPT ); Thu, 20 Sep 2018 05:56:37 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BAF7010903027; Wed, 19 Sep 2018 21:15:16 -0700 (PDT) Date: Wed, 19 Sep 2018 21:15:16 -0700 (PDT) Message-Id: <20180919.211516.509453409514254565.davem@davemloft.net> To: antoine.tenart@bootlin.com Cc: linux@armlinux.org.uk, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com Subject: Re: [PATCH net-next 0/3] net: phy: phylink: ensure the carrier is off when starting phylink From: David Miller In-Reply-To: <20180919093933.24411-1-antoine.tenart@bootlin.com> References: <20180919093933.24411-1-antoine.tenart@bootlin.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Sep 2018 21:15:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart Date: Wed, 19 Sep 2018 11:39:30 +0200 > Hi Russell, > > Following the discussion we had regarding the phylink issue related to > the carrier link state not being off when starting phylink, I sent a fix > patch a few days ago for the PPv2 driver: > https://lkml.org/lkml/2018/9/14/633 > > The idea was to send a patch which could go to the stable branches, but > a better solution would be to directly call netif_carrier_off() from > within phylink_start(). This is the aim of this series. Series applied.