From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CE4C433F4 for ; Wed, 19 Sep 2018 12:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03C492151B for ; Wed, 19 Sep 2018 12:40:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03C492151B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731860AbeISSSC (ORCPT ); Wed, 19 Sep 2018 14:18:02 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:59820 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728192AbeISSSC (ORCPT ); Wed, 19 Sep 2018 14:18:02 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1g2bm1-0002um-Io; Wed, 19 Sep 2018 14:40:05 +0200 Date: Wed, 19 Sep 2018 14:40:05 +0200 From: Florian Westphal To: zhong jiang Cc: davem@davemloft.net, kadlec@blackhole.kfki.hu, pablo@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: get rid of double sizeof Message-ID: <20180919124005.eidjr2qtryrongae@breakpoint.cc> References: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhong jiang wrote: > sizeof(sizeof()) is quite strange and does not seem to be what > is wanted here. Fixes: 39215846740a9f ("netfilter: conntrack: remove nlattr_size pointer from l4proto trackers") Acked-by: Florian Westphal