From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16413ECE561 for ; Thu, 20 Sep 2018 10:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC3CF21529 for ; Thu, 20 Sep 2018 10:39:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC3CF21529 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732449AbeITQWc (ORCPT ); Thu, 20 Sep 2018 12:22:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40128 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbeITQWc (ORCPT ); Thu, 20 Sep 2018 12:22:32 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id EA78CED4; Thu, 20 Sep 2018 10:39:40 +0000 (UTC) Date: Thu, 20 Sep 2018 12:39:38 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: Herbert Xu , Felipe Balbi , Johan Hovold , "Gustavo A. R. Silva" , linux-usb@vger.kernel.org, Ard Biesheuvel , Eric Biggers , linux-crypto , Linux Kernel Mailing List Subject: Re: [PATCH crypto-next 11/23] wusb: Remove VLA usage of skcipher Message-ID: <20180920103938.GA14523@kroah.com> References: <20180919021100.3380-1-keescook@chromium.org> <20180919021100.3380-12-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919021100.3380-12-keescook@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 07:10:48PM -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > replaces struct crypto_skcipher and SKCIPHER_REQUEST_ON_STACK() usage > with struct crypto_sync_skcipher and SYNC_SKCIPHER_REQUEST_ON_STACK(), > which uses a fixed stack size. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > > Cc: Greg Kroah-Hartman > Cc: Felipe Balbi > Cc: Johan Hovold > Cc: "Gustavo A. R. Silva" > Cc: linux-usb@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Greg Kroah-Hartman