From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 230FFECE566 for ; Thu, 20 Sep 2018 16:23:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D06DF2147D for ; Thu, 20 Sep 2018 16:23:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D06DF2147D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730654AbeITWHR (ORCPT ); Thu, 20 Sep 2018 18:07:17 -0400 Received: from mail.us.es ([193.147.175.20]:35332 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbeITWHQ (ORCPT ); Thu, 20 Sep 2018 18:07:16 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 70DECB5089 for ; Thu, 20 Sep 2018 18:23:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 625EDDA73F for ; Thu, 20 Sep 2018 18:23:00 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 4D441DA8FC; Thu, 20 Sep 2018 18:23:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 6CFCBDA8F6; Thu, 20 Sep 2018 18:22:58 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 20 Sep 2018 18:22:58 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.245.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 3B2AC4265A32; Thu, 20 Sep 2018 18:22:58 +0200 (CEST) Date: Thu, 20 Sep 2018 18:22:56 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: zhong jiang Cc: davem@davemloft.net, kadlec@blackhole.kfki.hu, fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: get rid of double sizeof Message-ID: <20180920162256.yrjkxw6n7q75ibom@salvia> References: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2018 at 08:21:11PM +0800, zhong jiang wrote: > sizeof(sizeof()) is quite strange and does not seem to be what > is wanted here. > > The issue is detected with the help of Coccinelle. Applied to nf, thanks.