From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peng Hao <penghao122@sina.com.cn>,
rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
x86@kernel.org, peng.hao2@zte.com,
Peng Hao <peng.hao2@zte.com.cn>
Subject: Re: [PATCH RESEND] kvm/x86: propagate fetch fault into guest
Date: Thu, 20 Sep 2018 10:42:45 -0700 [thread overview]
Message-ID: <20180920174245.GA10381@linux.intel.com> (raw)
In-Reply-To: <a3f05921-d802-efd6-65bb-7cb99f804f0f@redhat.com>
On Thu, Sep 20, 2018 at 06:32:10PM +0200, Paolo Bonzini wrote:
> On 19/09/2018 16:33, Sean Christopherson wrote:
> > On Tue, 2018-09-18 at 19:03 -0400, Peng Hao wrote:
> >> From: Peng Hao <peng.hao2@zte.com.cn>
> >>
> >> When handling ept misconfig exit, it will call emulate instruction
> >> with insn_len = 0. The decode instruction function may return a fetch
> >> fault and should propagate to guest.
> >
> > What fault is encountered, e.g. #PF, #UD, etc...? Something like a
> > #UD at this point should result in an exit to userspace as it means
> > KVM was unable to emulate an instruction that was successfully
> > decoded by hardware.
>
> If it's the same bug as https://lore.kernel.org/patchwork/patch/850077/
> it would be a #PF.
Indeed it is, let's move this discussion to that thread.
prev parent reply other threads:[~2018-09-20 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 23:03 Peng Hao
2018-09-19 14:33 ` Sean Christopherson
2018-09-20 16:32 ` Paolo Bonzini
2018-09-20 17:42 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920174245.GA10381@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peng.hao2@zte.com \
--cc=peng.hao2@zte.com.cn \
--cc=penghao122@sina.com.cn \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome