From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH v4 6/7] [media] ad5820: Add support for ad5821 and ad5823
Date: Thu, 20 Sep 2018 22:47:50 +0200 [thread overview]
Message-ID: <20180920204751.29117-6-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <20180920204751.29117-1-ricardo.ribalda@gmail.com>
According to the datasheet, both AD5821 and AD5820 share a compatible
register-set:
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5821.pdf
Some camera modules also refer that AD5823 is a replacement of AD5820:
https://download.kamami.com/p564094-OV8865_DS.pdf
Suggested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/media/i2c/ad5820.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 5d1185e7f78d..c52af302d516 100644
--- a/drivers/media/i2c/ad5820.c
+++ b/drivers/media/i2c/ad5820.c
@@ -34,8 +34,6 @@
#include <media/v4l2-device.h>
#include <media/v4l2-subdev.h>
-#define AD5820_NAME "ad5820"
-
/* Register definitions */
#define AD5820_POWER_DOWN (1 << 15)
#define AD5820_DAC_SHIFT 4
@@ -368,7 +366,9 @@ static int ad5820_remove(struct i2c_client *client)
}
static const struct i2c_device_id ad5820_id_table[] = {
- { AD5820_NAME, 0 },
+ { "ad5820", 0 },
+ { "ad5821", 0 },
+ { "ad5823", 0 },
{ }
};
MODULE_DEVICE_TABLE(i2c, ad5820_id_table);
@@ -376,6 +376,8 @@ MODULE_DEVICE_TABLE(i2c, ad5820_id_table);
#ifdef CONFIG_OF
static const struct of_device_id ad5820_of_table[] = {
{ .compatible = "adi,ad5820" },
+ { .compatible = "adi,ad5821" },
+ { .compatible = "adi,ad5823" },
{ }
};
MODULE_DEVICE_TABLE(of, ad5820_of_table);
@@ -384,6 +386,8 @@ MODULE_DEVICE_TABLE(of, ad5820_of_table);
#ifdef CONFIG_ACPI
static const struct acpi_device_id ad5820_acpi_ids[] = {
{ "AD5820" },
+ { "AD5821" },
+ { "AD5823" },
{ }
};
@@ -394,7 +398,7 @@ static SIMPLE_DEV_PM_OPS(ad5820_pm, ad5820_suspend, ad5820_resume);
static struct i2c_driver ad5820_i2c_driver = {
.driver = {
- .name = AD5820_NAME,
+ .name = "ad5820",
.pm = &ad5820_pm,
.of_match_table = of_match_ptr(ad5820_of_table),
.acpi_match_table = ACPI_PTR(ad5820_acpi_ids),
--
2.18.0
next prev parent reply other threads:[~2018-09-20 20:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 20:47 [PATCH v4 1/7] [media] ad5820: Define entity function Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 2/7] [media] ad5820: Add support for enable pin Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 3/7] [media] ad5820: DT new optional field enable-gpios Ricardo Ribalda Delgado
2018-09-27 18:23 ` Rob Herring
2018-10-01 8:20 ` Ricardo Ribalda Delgado
2018-10-01 12:36 ` Rob Herring
2018-10-01 12:40 ` Ricardo Ribalda Delgado
2018-10-01 15:01 ` Rob Herring
2018-10-01 15:55 ` Laurent Pinchart
2018-10-02 7:18 ` Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 4/7] [media] ad5820: Add support for of-autoload Ricardo Ribalda Delgado
2018-09-27 19:29 ` Sakari Ailus
2018-09-20 20:47 ` [PATCH v4 5/7] [media] ad5820: Add support for acpi autoload Ricardo Ribalda Delgado
2018-09-27 19:32 ` Sakari Ailus
2018-09-20 20:47 ` Ricardo Ribalda Delgado [this message]
2018-09-27 19:35 ` [PATCH v4 6/7] [media] ad5820: Add support for ad5821 and ad5823 Sakari Ailus
2018-10-01 8:19 ` Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 7/7] [media] ad5820: DT new compatible devices Ricardo Ribalda Delgado
2018-09-27 18:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920204751.29117-6-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome