From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93C9ECE562 for ; Fri, 21 Sep 2018 09:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 817C62154D for ; Fri, 21 Sep 2018 09:15:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 817C62154D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389537AbeIUPD2 (ORCPT ); Fri, 21 Sep 2018 11:03:28 -0400 Received: from mail.skyhub.de ([5.9.137.197]:35808 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389022AbeIUPD1 (ORCPT ); Fri, 21 Sep 2018 11:03:27 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4p7fYXscEuug; Fri, 21 Sep 2018 11:15:30 +0200 (CEST) Received: from nazgul.tnic (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9D0351EC0118; Fri, 21 Sep 2018 11:15:30 +0200 (CEST) Date: Fri, 21 Sep 2018 11:15:32 +0200 From: Borislav Petkov To: Manish Narani Cc: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab@kernel.org" , Michal Simek , "leoyang.li@nxp.com" , "sudeep.holla@arm.com" , "amit.kucheria@linaro.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller Message-ID: <20180921091532.GC30439@nazgul.tnic> References: <1537194305-9243-1-git-send-email-manish.narani@xilinx.com> <1537194305-9243-3-git-send-email-manish.narani@xilinx.com> <20180918075522.GC22202@nazgul.tnic> <20180919111553.GA9140@nazgul.tnic> <20180921090721.GB30439@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180921090721.GB30439@nazgul.tnic> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's more: I said: > > @@ -370,12 +398,12 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) > That function returns 0 unconditionally. Make it a void in a prepatch. But you've lumped this change together with a bunch more. Maybe my request wasn't clear so let me rephrase it: That function returns 0 unconditionally. Make it a void in a *separate* prepatch. Ok? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --