Re: [PATCH] scheduler: conditional statement cleanup

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]

Hi Pierce,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on v4.19-rc4 next-20180921]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/PierceGriffiths/scheduler-conditional-statement-cleanup/20180922-144638
config: x86_64-randconfig-x019-201837 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   kernel/sched/rt.c: In function 'move_entity':
>> kernel/sched/rt.c:1214:1: error: expected ';' before '}' token
    }
    ^

vim +1214 kernel/sched/rt.c

63489e45 kernel/sched_rt.c Steven Rostedt   2008-01-25  1205  
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1206  /*
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1207   * Change rt_se->run_list location unless SAVE && !MOVE
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1208   *
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1209   * assumes ENQUEUE/DEQUEUE flags match
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1210   */
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1211  static inline bool move_entity(unsigned int flags)
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1212  {
4f659495 kernel/sched/rt.c Pierce Griffiths 2018-09-21  1213  	return !((flags & (DEQUEUE_SAVE | DEQUEUE_MOVE)) == DEQUEUE_SAVE)
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18 @1214  }
ff77e468 kernel/sched/rt.c Peter Zijlstra   2016-01-18  1215  

:::::: The code at line 1214 was first introduced by commit
:::::: ff77e468535987b3d21b7bd4da15608ea3ce7d0b sched/rt: Fix PI handling vs. sched_setscheduler()

:::::: TO: Peter Zijlstra <peterz@infradead.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24418 bytes --]