From: Michal Hocko <mhocko@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] mm/migrate: Split only transparent huge pages when allocation fails
Date: Mon, 24 Sep 2018 18:52:42 +0200 [thread overview]
Message-ID: <20180924164733.GG18685@dhcp22.suse.cz> (raw)
In-Reply-To: <421f9b78-cb0f-01ce-dca0-93ff6eae0816@arm.com>
On Mon 24-09-18 22:10:30, Anshuman Khandual wrote:
>
>
> On 09/24/2018 08:00 PM, Michal Hocko wrote:
> > On Mon 24-09-18 19:44:55, Anshuman Khandual wrote:
> >> When unmap_and_move[_huge_page] function fails due to lack of memory, the
> >> splitting should happen only for transparent huge pages not for HugeTLB
> >> pages. PageTransHuge() returns true for both THP and HugeTLB pages. Hence
> >> the conditonal check should test PagesHuge() flag to make sure that given
> >> pages is not a HugeTLB one.
> >
> > Well spotted! Have you actually seen this happening or this is review
> > driven? I am wondering what would be the real effect of this mismatch?
> > I have tried to follow to code path but I suspect
> > split_huge_page_to_list would fail for hugetlbfs pages. If there is a
> > more serious effect then we should mark the patch for stable as well.
>
> split_huge_page_to_list() fails on HugeTLB pages. I was experimenting around
> moving 32MB contig HugeTLB pages on arm64 (with a debug patch applied) hit
> the following stack trace when the kernel crashed.
>
> [ 3732.462797] Call trace:
> [ 3732.462835] split_huge_page_to_list+0x3b0/0x858
> [ 3732.462913] migrate_pages+0x728/0xc20
> [ 3732.462999] soft_offline_page+0x448/0x8b0
> [ 3732.463097] __arm64_sys_madvise+0x724/0x850
> [ 3732.463197] el0_svc_handler+0x74/0x110
> [ 3732.463297] el0_svc+0x8/0xc
> [ 3732.463347] Code: d1000400 f90b0e60 f2fbd5a2 a94982a1 (f9000420)
Please make sure this makes it to the changelog and mark the patch for
stable.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2018-09-24 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 14:14 Anshuman Khandual
2018-09-24 14:30 ` Michal Hocko
2018-09-24 16:40 ` Anshuman Khandual
2018-09-24 16:52 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924164733.GG18685@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®