From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9CAC43382 for ; Tue, 25 Sep 2018 14:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F112D2098A for ; Tue, 25 Sep 2018 14:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="EnD0ydEU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F112D2098A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729964AbeIYVHf (ORCPT ); Tue, 25 Sep 2018 17:07:35 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:41314 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729364AbeIYVHd (ORCPT ); Tue, 25 Sep 2018 17:07:33 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8PErfpv141512; Tue, 25 Sep 2018 14:58:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=O/Vt+DuXUTePZhiaTARl4B6DfoukPsYxaM2Aj8pKbPY=; b=EnD0ydEUQQTIJW9h/oe+f6fVHGS7l8Mqo8YjDuU6v9uzLYXqnn2F6sD4opI/tRcXchDL uI5AdZJKENedLGIC693cY+Ddtbpxa0zx1glP0gqG5DsKA2lBlHOb2Wc+/ilrvaO877UF 5vYw7VabSOGdUAjnsYuzxurEs2fbPouMjDrjiOTDhW5GqWb79Hts9I4Z4ByuwwiuFmyx 128wdDp81VH7wHxg4CN3kfbqixksevL9FUFEaFIR62diP1m4n1lmCRwpkwJJzAwpdiR7 dGkrgZM55rY9Lm48dYXDRZcUU2y9N1xStCqBPy7X02eIh7nwkniUo0sSvdi9pkqil+GK jQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2mndppcp5s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Sep 2018 14:58:33 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w8PEwWeK016638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Sep 2018 14:58:33 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w8PEwUrC032529; Tue, 25 Sep 2018 14:58:31 GMT Received: from mwanda (/197.232.248.111) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 25 Sep 2018 07:58:30 -0700 Date: Tue, 25 Sep 2018 17:58:21 +0300 From: Dan Carpenter To: Colin King Cc: Linus Walleij , Matthias Brugger , Sean Wang , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: paris: fix check on EINT_NA comparison Message-ID: <20180925145821.bwumsuzz4tgsxc4b@mwanda> References: <20180925132130.27044-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180925132130.27044-1-colin.king@canonical.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9026 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=960 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809250149 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2018 at 02:21:30PM +0100, Colin King wrote: > From: Colin Ian King > > Currently, the check on desc->eint.eint_n == EINT_NA is always false > because this is comparing a u16 to -1 which can never be true. Fix > this by casting EINT_NA to u16. > > Fixes: fb5fa8dc151b ("pinctrl: mediatek: extend struct mtk_pin_desc to pinctrl-mtk-common-v2.c") > Signed-off-by: Colin Ian King > --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index 4cf0fea30b7d..77d380145dfd 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -729,7 +729,7 @@ static int mtk_gpio_to_irq(struct gpio_chip *chip, unsigned int offset) > > desc = (const struct mtk_pin_desc *)&hw->soc->pins[offset]; > > - if (desc->eint.eint_n == EINT_NA) > + if (desc->eint.eint_n == (u16)EINT_NA) Adding casts is ugly... I reported this earlier and think Sean Wang is going to send a fix for it. regards, dan carpenter