From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B51C43382 for ; Thu, 27 Sep 2018 03:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE6EF2152C for ; Thu, 27 Sep 2018 03:19:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE6EF2152C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbeI0Jfo (ORCPT ); Thu, 27 Sep 2018 05:35:44 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37618 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726469AbeI0Jfo (ORCPT ); Thu, 27 Sep 2018 05:35:44 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A2F0F1456FE19; Wed, 26 Sep 2018 20:19:40 -0700 (PDT) Date: Wed, 26 Sep 2018 20:19:40 -0700 (PDT) Message-Id: <20180926.201940.800778593716150299.davem@davemloft.net> To: natechancellor@gmail.com Cc: Ariel.Elior@cavium.com, everest-linux-l2@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] qed: Avoid implicit enum conversion in qed_roce_mode_to_flavor From: David Miller In-Reply-To: <20180924213452.19334-1-natechancellor@gmail.com> References: <20180924213120.18979-1-natechancellor@gmail.com> <20180924213452.19334-1-natechancellor@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Sep 2018 20:19:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor Date: Mon, 24 Sep 2018 14:34:53 -0700 > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/ethernet/qlogic/qed/qed_roce.c:153:12: warning: implicit > conversion from enumeration type 'enum roce_mode' to different > enumeration type 'enum roce_flavor' [-Wenum-conversion] > flavor = ROCE_V2_IPV6; > ~ ^~~~~~~~~~~~ > drivers/net/ethernet/qlogic/qed/qed_roce.c:156:12: warning: implicit > conversion from enumeration type 'enum roce_mode' to different > enumeration type 'enum roce_flavor' [-Wenum-conversion] > flavor = MAX_ROCE_MODE; > ~ ^~~~~~~~~~~~~ > 2 warnings generated. > > Use the appropriate values from the expected type, roce_flavor: > > ROCE_V2_IPV6 = RROCE_IPV6 = 2 > MAX_ROCE_MODE = MAX_ROCE_FLAVOR = 3 > > While we're add it, ditch the local variable flavor, we can just return > the value directly from the switch statement. > > Link: https://github.com/ClangBuiltLinux/linux/issues/125 > Signed-off-by: Nathan Chancellor > --- > > v1 -> v2: > > * s/if statement/switch statement/ in commit message Applied.