From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9735C43382 for ; Wed, 26 Sep 2018 10:41:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9ABA420843 for ; Wed, 26 Sep 2018 10:41:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ABA420843 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727572AbeIZQx1 (ORCPT ); Wed, 26 Sep 2018 12:53:27 -0400 Received: from mail.bootlin.com ([62.4.15.54]:41850 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbeIZQx1 (ORCPT ); Wed, 26 Sep 2018 12:53:27 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id A347720901; Wed, 26 Sep 2018 12:41:04 +0200 (CEST) Received: from localhost (nat-240.udc.es [193.144.61.240]) by mail.bootlin.com (Postfix) with ESMTPSA id 3D968203DA; Wed, 26 Sep 2018 12:40:54 +0200 (CEST) Date: Wed, 26 Sep 2018 12:40:53 +0200 From: Maxime Ripard To: Laurent Pinchart Cc: Yong Deng , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "\"David S. Miller" , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Jacob Chen , Neil Armstrong , Thierry Reding , Philipp Zabel , Todor Tomov , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Message-ID: <20180926104053.ijhmvvsbju36j4d3@flea> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <7197338.mhOH8fQaEM@avalon> <20180926103547.5ubb6xjkl7xngmfg@flea> <1568838.d8CnAYTeDB@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1568838.d8CnAYTeDB@avalon> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 01:38:08PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > On Wednesday, 26 September 2018 13:35:47 EEST maxime.ripard@bootlin.com wrote: > > On Wed, Sep 26, 2018 at 01:19:34PM +0300, Laurent Pinchart wrote: > > > > +Endpoint node properties for CSI1 > > > > +--------------------------------- > > > > > > Should you list the CSI0 properties as well ? As the driver in patch 2/2 > > > doesn't support the CSI-2 interface I assume you have left out CSI0 for > > > now, but it should still be listed in the bindings. I'm fine with fixing > > > this as a follow-up patch to avoid missing the v4.20 merge window, but if > > > you end up resubmitting the series, could you please address the problem > > > ? > > > > That driver is not available, and the documentation isn't either, so > > there's no easy way to tell which properties are going to be needed > > before doing the actual work of reverse engineering it and writing a > > driver for it. Unfortunately... > > While DT bindings should be independent from driver implementations, I agree > it's difficult to develop good bindings without hardware documentation and > without at least one working driver implementation. > > How about just explicitly stating that these bindings don't support CSI0 yet ? Yep, that would work -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com