mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Gross <andy.gross@linaro.org>
To: Brian Masney <masneyb@onstation.org>
Cc: linux-arm-msm@vger.kernel.org, david.brown@linaro.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, frank.rowand@sony.com
Subject: Re: [PATCH ARM-next] ARM: dts: qcom-msm8974: change invalid flag IRQ NONE to valid value
Date: Wed, 26 Sep 2018 11:43:24 -0500	[thread overview]
Message-ID: <20180926164324.GA20233@hector.attlocal.net> (raw)
In-Reply-To: <20180925104651.16596-1-masneyb@onstation.org>

On Tue, Sep 25, 2018 at 06:46:51AM -0400, Brian Masney wrote:
> The following commits used IRQ_TYPE_NONE since that matched what was
> already in the file and I do not have access to the datasheets for
> these devices. After these patches were submitted, commit dcf145011400
> ("ARM: dts: qcom-msm8974: change invalid flag IRQ NONE to valid value")
> changed all of these values to IRQ_TYPE_LEVEL_HIGH. This patch corrects
> the IRQ type for these two commits:
> 
> commit bd9392507588 ("ARM: dts: qcom: msm8974-hammerhead: add device
> tree bindings for ALS / proximity")
> 
> commit fe8d81fe7d9a ("ARM: dts: qcom: msm8974-hammerhead: add device
> tree bindings for mpu6515") 
> 
> Prior to these patches, I was having issues with the bmp280 sensor
> returning temperature / pressure skipped errors, however these errors
> have gone away with these patches.
> 
> Patches were tested on a LG Nexus 5 (hammerhead) phone.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---

Thanks for submitting this fix.  I added it and it will be part of the pull
request.

Thanks,

Andy

      reply	other threads:[~2018-09-26 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 10:46 Brian Masney
2018-09-26 16:43 ` Andy Gross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180926164324.GA20233@hector.attlocal.net \
    --to=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frank.rowand@sony.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=masneyb@onstation.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®