Re: [PATCH v2] Revert: "f2fs: check last page index in cached bio to decide submission"

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3540 bytes --]

Hi Chao,

I love your patch! Perhaps something to improve:

[auto build test WARNING on f2fs/dev-test]
[also build test WARNING on v4.19-rc5 next-20180926]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chao-Yu/Revert-f2fs-check-last-page-index-in-cached-bio-to-decide-submission/20180926-195004
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   fs/f2fs/checkpoint.c: In function '__f2fs_write_meta_page':
>> fs/f2fs/checkpoint.c:283:8: warning: passing argument 3 of 'f2fs_submit_merged_write_cond' makes pointer from integer without a cast [-Wint-conversion]
           page->index, 0, META);
           ^~~~
   In file included from fs/f2fs/checkpoint.c:17:0:
   fs/f2fs/f2fs.h:3030:6: note: expected 'struct page *' but argument is of type 'long unsigned int'
    void f2fs_submit_merged_write_cond(struct f2fs_sb_info *sbi,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   fs/f2fs/data.c: In function '__write_data_page':
>> fs/f2fs/data.c:1955:45: warning: passing argument 3 of 'f2fs_submit_merged_write_cond' makes pointer from integer without a cast [-Wint-conversion]
      f2fs_submit_merged_write_cond(sbi, inode, page->index, 0, DATA);
                                                ^~~~
   fs/f2fs/data.c:423:6: note: expected 'struct page *' but argument is of type 'long unsigned int'
    void f2fs_submit_merged_write_cond(struct f2fs_sb_info *sbi,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   fs/f2fs/node.c: In function '__write_node_page':
>> fs/f2fs/node.c:1565:7: warning: passing argument 3 of 'f2fs_submit_merged_write_cond' makes pointer from integer without a cast [-Wint-conversion]
          page->index, 0, NODE);
          ^~~~
   In file included from fs/f2fs/node.c:16:0:
   fs/f2fs/f2fs.h:3030:6: note: expected 'struct page *' but argument is of type 'long unsigned int'
    void f2fs_submit_merged_write_cond(struct f2fs_sb_info *sbi,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/f2fs_submit_merged_write_cond +283 fs/f2fs/checkpoint.c

   262	
   263	static int __f2fs_write_meta_page(struct page *page,
   264					struct writeback_control *wbc,
   265					enum iostat_type io_type)
   266	{
   267		struct f2fs_sb_info *sbi = F2FS_P_SB(page);
   268	
   269		trace_f2fs_writepage(page, META);
   270	
   271		if (unlikely(f2fs_cp_error(sbi)))
   272			goto redirty_out;
   273		if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
   274			goto redirty_out;
   275		if (wbc->for_reclaim && page->index < GET_SUM_BLOCK(sbi, 0))
   276			goto redirty_out;
   277	
   278		f2fs_do_write_meta_page(sbi, page, io_type);
   279		dec_page_count(sbi, F2FS_DIRTY_META);
   280	
   281		if (wbc->for_reclaim)
   282			f2fs_submit_merged_write_cond(sbi, page->mapping->host,
 > 283								page->index, 0, META);
   284	
   285		unlock_page(page);
   286	
   287		if (unlikely(f2fs_cp_error(sbi)))
   288			f2fs_submit_merged_write(sbi, META);
   289	
   290		return 0;
   291	
   292	redirty_out:
   293		redirty_page_for_writepage(wbc, page);
   294		return AOP_WRITEPAGE_ACTIVATE;
   295	}
   296	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65106 bytes --]