mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: rkir@google.com
Cc: linux-kernel@vger.kernel.org, tkjos@google.com,
	Lingfeng Yang <lfy@google.com>
Subject: Re: [PATCH v2 06/21] platform: goldfish: pipe: Add DMA support to goldfish pipe
Date: Thu, 27 Sep 2018 07:19:25 +0200	[thread overview]
Message-ID: <20180927051925.GA473@kroah.com> (raw)
In-Reply-To: <20180926230222.126513-1-rkir@google.com>

On Wed, Sep 26, 2018 at 04:02:19PM -0700, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
> 
> Goldfish DMA is an extension to the pipe device and is designed
> to facilitate high-speed RAM->RAM transfers from guest to host.
> 
> See uapi/linux/goldfish/goldfish_dma.h for more details.
> 
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> Signed-off-by: Lingfeng Yang <lfy@google.com>
> ---
> Changes in v2:
>  - Got sign-off from Lingfeng Yang.
>  - Removed the license boilerplate from goldfish_dma.h.
>  - Rebased.

I don't understand this series.  Please start over with 01/XX as your
other patches were all merged.

And I still think you need a better justification for this, given the
many other ways the kernel already has for this feature...

thanks,

greg k-h

      parent reply	other threads:[~2018-09-27  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 23:02 rkir
2018-09-26 23:02 ` [PATCH v2 09/21] platform: goldfish: pipe: Remove the goldfish_pipe_dev global variable rkir
2018-09-26 23:02 ` [PATCH v2 13/21] platform: goldfish: pipe: Split the driver to v2 specific and the rest rkir
2018-09-26 23:02 ` [PATCH v2 19/21] platform: goldfish: pipe: Add the goldfish_pipe_v1 driver rkir
2018-09-27  5:19 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927051925.GA473@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=lfy@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkir@google.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome