From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244CCC43382 for ; Thu, 27 Sep 2018 07:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB46E2156E for ; Thu, 27 Sep 2018 07:52:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB46E2156E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727199AbeI0OJS (ORCPT ); Thu, 27 Sep 2018 10:09:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:47308 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726708AbeI0OJS (ORCPT ); Thu, 27 Sep 2018 10:09:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0398BADA8; Thu, 27 Sep 2018 07:52:20 +0000 (UTC) Date: Thu, 27 Sep 2018 09:52:20 +0200 From: Petr Mladek To: Rasmus Villemoes Cc: Jason Baron , Andrew Morton , linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH 05/22] linux/printk.h: use DYNAMIC_DEBUG_BRANCH in pr_debug_ratelimited Message-ID: <20180927075220.w4fptezlycovaniv@pathway.suse.cz> References: <20180919220444.23190-1-linux@rasmusvillemoes.dk> <20180919220444.23190-6-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919220444.23190-6-linux@rasmusvillemoes.dk> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2018-09-20 00:04:27, Rasmus Villemoes wrote: > pr_debug_ratelimited tests the dynamic debug descriptor the old-fashioned > way, and doesn't utilize the static key/jump label implementation on > architectures that HAVE_JUMP_LABEL. Use the DYNAMIC_DEBUG_BRANCH which > is defined appropriately. > > Cc: Petr Mladek > Cc: Steven Rostedt > Signed-off-by: Rasmus Villemoes Acked-by: Petr Mladek It is an independent fix. I am going to take it via printk.git unless anyone is against it. Best Regards, Petr > --- > include/linux/printk.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/printk.h b/include/linux/printk.h > index cf3eccfe1543..d3ba3245531d 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -466,7 +466,7 @@ do { \ > DEFAULT_RATELIMIT_INTERVAL, \ > DEFAULT_RATELIMIT_BURST); \ > DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, pr_fmt(fmt)); \ > - if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT) && \ > + if (DYNAMIC_DEBUG_BRANCH(descriptor) && \ > __ratelimit(&_rs)) \ > __dynamic_pr_debug(&descriptor, pr_fmt(fmt), ##__VA_ARGS__); \ > } while (0) > -- > 2.16.4 >