From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036E7C43382 for ; Thu, 27 Sep 2018 10:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 925E32159D for ; Thu, 27 Sep 2018 10:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 925E32159D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727240AbeI0RLq (ORCPT ); Thu, 27 Sep 2018 13:11:46 -0400 Received: from mga05.intel.com ([192.55.52.43]:35226 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727057AbeI0RLp (ORCPT ); Thu, 27 Sep 2018 13:11:45 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 03:54:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,310,1534834800"; d="scan'208";a="93767418" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 27 Sep 2018 03:54:02 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 27 Sep 2018 13:54:01 +0300 Date: Thu, 27 Sep 2018 13:54:01 +0300 From: Heikki Krogerus To: Adam Thomson Cc: Guenter Roeck , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, support.opensource@diasemi.com Subject: Re: [PATCH 2/2] usb: typec: fusb302: Resolve fixed power role contract setup Message-ID: <20180927105401.GO11965@kuha.fi.intel.com> References: <383410593681e2fed025a4b538ea0840ff370a9a.1537975081.git.Adam.Thomson.Opensource@diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <383410593681e2fed025a4b538ea0840ff370a9a.1537975081.git.Adam.Thomson.Opensource@diasemi.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 04:23:52PM +0100, Adam Thomson wrote: > When the controller is configured for a fixed power role (Source > only or Sink only), attach does not proceed within the TCPM state > machine as there is no CC event generated by this driver to update > the CC line status. > > To rectify this, when CC is configured as Source or Sink we now > make use of the hardware's automatic fixed Source or Sink > toggling mechanism, which detects attaches in the same way as for > DRP toggling. In this way the result of toggling is handled in the > same way by the 'fusb302_handle_togdone()' function, and CC events > are generated as expected for TCPM allowing a contract to be > established. > > Signed-off-by: Adam Thomson Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm/fusb302.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c > index fd851d8..43b64d9 100644 > --- a/drivers/usb/typec/tcpm/fusb302.c > +++ b/drivers/usb/typec/tcpm/fusb302.c > @@ -679,6 +679,7 @@ static int tcpm_set_cc(struct tcpc_dev *dev, enum typec_cc_status cc) > int ret = 0; > bool pull_up, pull_down; > u8 rd_mda; > + enum toggling_mode mode; > > mutex_lock(&chip->lock); > switch (cc) { > @@ -764,6 +765,29 @@ static int tcpm_set_cc(struct tcpc_dev *dev, enum typec_cc_status cc) > chip->intr_comp_chng = false; > } > fusb302_log(chip, "cc := %s", typec_cc_status_name[cc]); > + > + /* Enable detection for fixed SNK or SRC only roles */ > + switch (cc) { > + case TYPEC_CC_RD: > + mode = TOGGLING_MODE_SNK; > + break; > + case TYPEC_CC_RP_DEF: > + case TYPEC_CC_RP_1_5: > + case TYPEC_CC_RP_3_0: > + mode = TOGGLING_MODE_SRC; > + break; > + default: > + mode = TOGGLING_MODE_OFF; > + break; > + } > + > + if (mode != TOGGLING_MODE_OFF) { > + ret = fusb302_set_toggling(chip, mode); > + if (ret < 0) > + fusb302_log(chip, > + "cannot set fixed role toggling mode, ret=%d", > + ret); > + } > done: > mutex_unlock(&chip->lock); > > -- > 1.9.1 -- heikki