From: Mark Brown <broonie@kernel.org>
To: "Đặng Trần Hiếu" <dangtranhieu2012@gmail.com>
Cc: robh@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: spi: fsl-lpspi: Option to allow stalling
Date: Thu, 27 Sep 2018 23:47:23 +0100 [thread overview]
Message-ID: <20180927224723.GF20825@sirena.org.uk> (raw)
In-Reply-To: <CAAObPoHOEYrDj8uoFK-gW8jvy8i-vtRhTkEEm5aVNn8ucLxRMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Wed, Sep 26, 2018 at 09:37:39PM +0700, Đặng Trần Hiếu wrote:
> Default value of the register is to allow stalling (NOSTALL bit not
> set) but the spi-fsl-lpspi driver defaults to setting the NOSTALL bit
> in CFGR1. To me, it's more logical to leave the NOSTALL bit off with
> fsl,nostall binding to set the bit but as I am not sure if there are
> other drivers depending on the NOSTALL bit being set and not wanting
> to break other drivers hence introduction of this binding to keep the
> current default behavior.
I can't see a situation where you'd actively want to report an error
rather than stall, stalling allows us to handle things gracefully by
restarting things. Even if it's a timeout situation it sounds like we
can unblock by reading/writing the stalled FIFO, and normally you'd be
resetting the entire IP anyway. I'd imagine the driver is this way
either through an oversight or because there's some bug on some silicon
which means that stalling breaks.
Probably best to just always enable stalling unless I'm misreading
things, if it is silicon bugs on some versions then either a whitelist
or blacklist of SoCs to enable on (depending on how common the bug is)
would be the way forwards - that way SoCs where it works get the benefit.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-27 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 20:36 [PATCH 0/2] spi: fsl-lpspi: Option to prevent FIFO under/overrun Hieu Tran Dang
2018-09-25 20:37 ` [PATCH 1/2] dt-bindings: spi: fsl-lpspi: Option to allow stalling Hieu Tran Dang
2018-09-26 14:26 ` Rob Herring
2018-09-26 14:37 ` Đặng Trần Hiếu
2018-09-27 22:47 ` Mark Brown [this message]
2018-10-01 1:12 ` Hieu Tran Dang
2018-09-25 20:37 ` [PATCH 2/2] spi: fsl-lpspi: Option to prevent FIFO under/overrun Hieu Tran Dang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927224723.GF20825@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dangtranhieu2012@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome