From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aymen Qader <qader.aymen@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v3] staging: ks7010: Add null pointer check for skb
Date: Fri, 28 Sep 2018 11:16:01 +0300 [thread overview]
Message-ID: <20180928081601.is2gl764krxcvtlv@mwanda> (raw)
In-Reply-To: <20180928081325.krgawue3cs6mavw2@mwanda>
Btw, if you have the cross function DB built then Smatch says that the
NULL check can be removed here no problem.
$ smdb hostif_data_request
[ snip ]
drivers/staging/ks7010/ks_wlan_net.c | ks_wlan_start_xmit | hostif_data_request | PARAM_VALUE | 1 | skb | s64min-(-1),1-s64max
regards,
dan carpenter
next prev parent reply other threads:[~2018-09-28 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 15:16 Aymen Qader
2018-09-27 18:04 ` Aymen Qader
2018-09-28 8:22 ` Dan Carpenter
2018-09-28 8:13 ` Dan Carpenter
2018-09-28 8:16 ` Dan Carpenter [this message]
2018-09-28 8:48 ` Aymen Qader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928081601.is2gl764krxcvtlv@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qader.aymen@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®