From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC3AC43382 for ; Fri, 28 Sep 2018 08:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6548220684 for ; Fri, 28 Sep 2018 08:35:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6548220684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729044AbeI1O5u (ORCPT ); Fri, 28 Sep 2018 10:57:50 -0400 Received: from foss.arm.com ([217.140.101.70]:44742 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbeI1O5u (ORCPT ); Fri, 28 Sep 2018 10:57:50 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B752C7A9; Fri, 28 Sep 2018 01:35:11 -0700 (PDT) Received: from queper01-lin (queper01-lin.emea.arm.com [10.4.13.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 753B03F5D3; Fri, 28 Sep 2018 01:35:07 -0700 (PDT) Date: Fri, 28 Sep 2018 09:35:05 +0100 From: Quentin Perret To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Peter Zijlstra , Linux Kernel Mailing List , Linux PM , Greg Kroah-Hartman , Ingo Molnar , Dietmar Eggemann , Morten Rasmussen , Chris Redpath , Patrick Bellasi , Valentin Schneider , Vincent Guittot , Thara Gopinath , Viresh Kumar , Todd Kjos , Joel Fernandes , Steve Muckle , adharmap@codeaurora.org, Saravana Kannan , Pavan Kondeti , Juri Lelli , Eduardo Valentin , Srinivas Pandruvada , currojerez@riseup.net, Javi Merino Subject: Re: [PATCH v7 02/14] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling Message-ID: <20180928083503.h4jbdgk3dqpaufzb@queper01-lin> References: <20180912091309.7551-1-quentin.perret@arm.com> <20180927121749.urdqtayq6ll4k7qn@queper01-lin> <2417577.QmA9JEQx1z@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2417577.QmA9JEQx1z@aspire.rjw.lan> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Friday 28 Sep 2018 at 10:23:42 (+0200), Rafael J. Wysocki wrote: [...] > OK, so please document the enum type. Will do. [...] > Documenting things properly is absolutely required. Understood. > The other changes suggested by me are rather straightforward, so why would it > be a problem to make them right away if you agree to make them? Right, if I need to spin a v8 for doc purpose anyway, I guess I can do the other small fixes at the same time. I'll wait a bit before sending the update to see if others have some feedback. It's probably a bit late for 4.20 anyway ... Or is it not ? Thanks, Quentin