From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE7C2C43143 for ; Sat, 29 Sep 2018 18:32:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6B8620880 for ; Sat, 29 Sep 2018 18:32:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6B8620880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728736AbeI3BBt (ORCPT ); Sat, 29 Sep 2018 21:01:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56912 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728197AbeI3BBt (ORCPT ); Sat, 29 Sep 2018 21:01:49 -0400 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EAF331476CF92; Sat, 29 Sep 2018 11:32:20 -0700 (PDT) Date: Sat, 29 Sep 2018 11:32:18 -0700 (PDT) Message-Id: <20180929.113218.1132517937797768271.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, steve.glendinning@shawell.net, keescook@chromium.org, akurz@blala.de, hayeswang@realtek.com, kai.heng.feng@canonical.com, grundler@chromium.org, zhongjiang@huawei.com, bigeasy@linutronix.de, ran.wang_1@nxp.com, edumazet@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 0/7] net: usb: Check for Wake-on-LAN modes From: David Miller In-Reply-To: <20180928231856.3587-1-f.fainelli@gmail.com> References: <20180928231856.3587-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 29 Sep 2018 11:32:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Fri, 28 Sep 2018 16:18:49 -0700 > Most of our USB Ethernet drivers don't seem to be checking properly > whether the user is supplying a correct Wake-on-LAN mode to enter, so > the experience as an user could be confusing, since it would generally > lead to either no wake-up, or the device not being marked for wake-up. > > Please review! > > Changes in v2: > > - fixed lan78xx handling, thanks Woojung! Series applied, thanks Florian.