From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41CBC43143 for ; Sat, 29 Sep 2018 17:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90E3A20879 for ; Sat, 29 Sep 2018 17:08:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90E3A20879 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbeI2Xhd (ORCPT ); Sat, 29 Sep 2018 19:37:33 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:42123 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728364AbeI2Xhd (ORCPT ); Sat, 29 Sep 2018 19:37:33 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1103432|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03298;MF=ren_guo@c-sky.com;NM=1;PH=DS;RN=18;RT=18;SR=0;TI=SMTPD_---.CxVmELg_1538240867; Received: from localhost(mailfrom:ren_guo@c-sky.com fp:SMTPD_---.CxVmELg_1538240867) by smtp.aliyun-inc.com(10.147.40.44); Sun, 30 Sep 2018 01:07:47 +0800 Date: Sun, 30 Sep 2018 01:07:46 +0800 From: Guo Ren To: Christoph Hellwig Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, peterz@infradead.org, robh@kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, green.hu@gmail.com Subject: Re: [PATCH V6 04/33] csky: Exception handling and mm-fault Message-ID: <20180929170746.GF27796@guoren-Inspiron-7460> References: <20180928161503.GC19827@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180928161503.GC19827@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2018 at 09:15:03AM -0700, Christoph Hellwig wrote: > > +#ifndef CONFIG_CPU_HAS_TLBI > > + /* > > + * We fault-in kernel-space virtual memory on-demand. The > > + * 'reference' page table is init_mm.pgd. > > + * > > + * NOTE! We MUST NOT take any locks for this case. We may > > + * be in an interrupt or a critical region, and should > > + * only copy the information from the master page table, > > + * nothing more. > > + */ > > + if (unlikely(address >= VMALLOC_START && address <= VMALLOC_END)) > > + { > > This doesn't fir the kernel style. Please run checkpatch.pl over > your code and fix at least all warnings that don't seem clearly bogus. if (unlikely(address >= VMALLOC_START) && unlikely(address <= VMALLOC_END)) { Ok, use checkpatch.pl. Best Regards Guo Ren