From: Chuanhua Han <chuanhua.han@nxp.com>
To: broonie@kernel.org
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
boris.brezillon@bootlin.com, eha@deif.com,
Chuanhua Han <chuanhua.han@nxp.com>
Subject: [PATCH v2 2/4] spi: spi-fsl-dspi: Fix delete the processing of undefined bitmask for rxdata
Date: Sun, 30 Sep 2018 17:25:33 +0800 [thread overview]
Message-ID: <20180930092535.24544-2-chuanhua.han@nxp.com> (raw)
In-Reply-To: <20180930092535.24544-1-chuanhua.han@nxp.com>
This patch fixes the problem of rxdata being equal to 0 during the XSPI
mode transfer of the dspi controller.
In XSPI mode, If it is not deleted, the value of rxdata will be equal
to 0, and the data received will not be received correctly, causing the
receiving transfer of the spi to fail.
Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
Changes in v2:
-The original patch is divided into multiple patches(the original
patch theme is "spi: spi-fsl-dspi: Fix support for XSPI transport
mode"),one of which is segmented.
drivers/spi/spi-fsl-dspi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 3082e72e4f6c..4dc1064bf408 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -243,9 +243,6 @@ static void dspi_push_rx(struct fsl_dspi *dspi, u32 rxdata)
if (!dspi->rx)
return;
- /* Mask of undefined bits */
- rxdata &= (1 << dspi->bits_per_word) - 1;
-
if (dspi->bytes_per_word == 1)
*(u8 *)dspi->rx = rxdata;
else if (dspi->bytes_per_word == 2)
--
2.17.1
next prev parent reply other threads:[~2018-09-30 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 9:25 [PATCH v2 1/4] spi: spi-mem: Add the spi_set_xfer_bpw function Chuanhua Han
2018-09-30 9:25 ` Chuanhua Han [this message]
2018-09-30 10:06 ` [PATCH v2 2/4] spi: spi-fsl-dspi: Fix delete the processing of undefined bitmask for rxdata Boris Brezillon
2018-09-30 10:10 ` Chuanhua Han
2018-09-30 10:17 ` Boris Brezillon
2018-09-30 10:37 ` Chuanhua Han
2018-09-30 10:37 ` Esben Haabendal
2018-09-30 10:41 ` Boris Brezillon
2018-09-30 10:29 ` Esben Haabendal
2018-09-30 9:25 ` [PATCH v2 3/4] spi: spi-fsl-dspi: Fix cmd_fifo is written before tx_fifo Chuanhua Han
2018-09-30 10:30 ` Esben Haabendal
2018-09-30 9:25 ` [PATCH v2 4/4] spi: spi-fsl-dspi: Fix adjust the byte order when sending and receiving data Chuanhua Han
2018-09-30 10:27 ` Esben Haabendal
2018-09-30 10:04 ` [PATCH v2 1/4] spi: spi-mem: Add the spi_set_xfer_bpw function Boris Brezillon
2018-09-30 10:17 ` Esben Haabendal
2018-09-30 10:40 ` Chuanhua Han
2018-09-30 10:18 ` Chuanhua Han
2018-09-30 10:40 ` Boris Brezillon
2018-09-30 10:48 ` Chuanhua Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180930092535.24544-2-chuanhua.han@nxp.com \
--to=chuanhua.han@nxp.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=eha@deif.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®