From: Dave Young <dyoung@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
dhowells@redhat.com, vgoyal@redhat.com,
herbert@gondor.apana.org.au, davem@davemloft.net, bhe@redhat.com,
arnd@arndb.de, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
ard.biesheuvel@linaro.org, bhsharma@redhat.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
prudo@linux.ibm.com, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 05/16] kexec_file: kexec_walk_memblock() only walks a dedicated region at kdump
Date: Sun, 30 Sep 2018 18:10:01 +0800 [thread overview]
Message-ID: <20180930101001.GE6950@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20180928064841.14117-6-takahiro.akashi@linaro.org>
On 09/28/18 at 03:48pm, AKASHI Takahiro wrote:
> In kdump case, there exists only one dedicated memblock region as usable
> memory (crashk_res). With this patch, kexec_walk_memblock() runs a given
> callback function on this region.
>
> Cosmetic change: 0 to MEMBLOCK_NONE at for_each_free_mem_range*()
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> Cc: Baoquan He <bhe@redhat.com>
Acked-by: Dave Young <dyoung@redhat.com>
> ---
> kernel/kexec_file.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 370d7eab49fe..2f615a7968dd 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -511,8 +511,11 @@ static int kexec_walk_memblock(struct kexec_buf *kbuf,
> phys_addr_t mstart, mend;
> struct resource res = { };
>
> + if (kbuf->image->type == KEXEC_TYPE_CRASH)
> + return func(&crashk_res, kbuf);
> +
> if (kbuf->top_down) {
> - for_each_free_mem_range_reverse(i, NUMA_NO_NODE, 0,
> + for_each_free_mem_range_reverse(i, NUMA_NO_NODE, MEMBLOCK_NONE,
> &mstart, &mend, NULL) {
> /*
> * In memblock, end points to the first byte after the
> @@ -526,8 +529,8 @@ static int kexec_walk_memblock(struct kexec_buf *kbuf,
> break;
> }
> } else {
> - for_each_free_mem_range(i, NUMA_NO_NODE, 0, &mstart, &mend,
> - NULL) {
> + for_each_free_mem_range(i, NUMA_NO_NODE, MEMBLOCK_NONE,
> + &mstart, &mend, NULL) {
> /*
> * In memblock, end points to the first byte after the
> * range while in kexec, end points to the last byte
> --
> 2.19.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
Thanks
Dave
next prev parent reply other threads:[~2018-09-30 10:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 6:48 [PATCH v15 00/16] arm64: kexec: add kexec_file_load() support AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 01/16] asm-generic: add kexec_file_load system call to unistd.h AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 02/16] kexec_file: make kexec_image_post_load_cleanup_default() global AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 03/16] s390, kexec_file: drop arch_kexec_mem_walk() AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 04/16] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem() AKASHI Takahiro
2018-09-30 10:08 ` Dave Young
2018-10-02 6:20 ` AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 05/16] kexec_file: kexec_walk_memblock() only walks a dedicated region at kdump AKASHI Takahiro
2018-09-30 10:10 ` Dave Young [this message]
2018-09-28 6:48 ` [PATCH v15 06/16] of/fdt: add helper functions for handling properties AKASHI Takahiro
2018-09-28 9:04 ` kbuild test robot
2018-09-28 13:44 ` Rob Herring
2018-09-28 21:13 ` Frank Rowand
2018-10-05 5:06 ` AKASHI, Takahiro
2018-10-05 5:09 ` David Gibson
2018-10-09 18:02 ` Frank Rowand
2018-10-10 0:30 ` David Gibson
2018-10-10 1:04 ` AKASHI, Takahiro
2018-10-02 4:47 ` David Gibson
2018-10-02 9:04 ` AKASHI, Takahiro
[not found] ` <20181005030849.GK32578@linaro.org>
2018-10-05 13:23 ` Rob Herring
2018-10-09 0:37 ` AKASHI, Takahiro
2018-10-09 17:47 ` Frank Rowand
2018-10-10 1:14 ` AKASHI, Takahiro
2018-10-10 2:44 ` Frank Rowand
2018-09-28 6:48 ` [PATCH v15 07/16] arm64: add image head flag definitions AKASHI Takahiro
2018-10-01 12:52 ` Mark Rutland
2018-10-02 7:59 ` AKASHI Takahiro
2018-10-09 15:04 ` Mark Rutland
2018-10-10 1:59 ` AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 08/16] arm64: cpufeature: add MMFR0 helper functions AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 09/16] arm64: enable KEXEC_FILE config AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 10/16] arm64: kexec_file: load initrd and device-tree AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 11/16] arm64: kexec_file: allow for loading Image-format kernel AKASHI Takahiro
2018-10-09 15:28 ` Mark Rutland
2018-10-10 6:52 ` AKASHI Takahiro
2018-10-10 9:47 ` Mark Rutland
2018-09-28 6:48 ` [PATCH v15 12/16] arm64: kexec_file: add crash dump support AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 13/16] arm64: kexec_file: invoke the kernel without purgatory AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 14/16] include: pe.h: remove message[] from mz header definition AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 15/16] arm64: kexec_file: add kernel signature verification support AKASHI Takahiro
2018-09-28 6:48 ` [PATCH v15 16/16] arm64: kexec_file: add kaslr support AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180930101001.GE6950@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prudo@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=takahiro.akashi@linaro.org \
--cc=vgoyal@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®