From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Abramov <st5pub@yandex.ru>
Cc: mchehab@kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] Staging: media: replaced deprecated probe method
Date: Mon, 1 Oct 2018 09:48:14 +0300 [thread overview]
Message-ID: <20181001064813.puc6ky4i55vmgn4q@mwanda> (raw)
In-Reply-To: <20180929185150.16657-1-st5pub@yandex.ru>
On Sat, Sep 29, 2018 at 09:51:50PM +0300, Andrey Abramov wrote:
> drivers/staging/media/bcm2048/radio-bcm2048.c replaced i2c_driver::probe with i2c_driver::probe_new, because documentation says that i2c_driver::probe "soon to be deprecated"
>
This needs to be line wrapped at 72 characters.
> Signed-off-by: Andrey Abramov <st5pub@yandex.ru>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index a90b2eb112f9..756f7f08c713 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2574,8 +2574,7 @@ static const struct video_device bcm2048_viddev_template = {
> /*
> * I2C driver interface
> */
> -static int bcm2048_i2c_driver_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int bcm2048_i2c_driver_probe_new(struct i2c_client *client)
Don't rename the function. Just remove the unused parameter.
regards,
dan carpenter
next prev parent reply other threads:[~2018-10-01 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 18:51 Andrey Abramov
2018-10-01 6:48 ` Dan Carpenter [this message]
2018-10-01 9:42 Andrey Abramov
2018-10-01 9:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001064813.puc6ky4i55vmgn4q@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=st5pub@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®