From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED87C43143 for ; Mon, 1 Oct 2018 18:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EF042089A for ; Mon, 1 Oct 2018 18:53:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EF042089A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbeJBBct (ORCPT ); Mon, 1 Oct 2018 21:32:49 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39508 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbeJBBct (ORCPT ); Mon, 1 Oct 2018 21:32:49 -0400 Received: by mail-pf1-f194.google.com with SMTP id j8-v6so9903367pff.6; Mon, 01 Oct 2018 11:53:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ks8aQKngydDGhwlATvyDlt0jiv3564bWZDPWlTAPtTk=; b=IauZHHo9seNAbU1SXmzGWk2j8uvQPhnTw4WFdeN3SeU3HrwzE3fPspr2YEbTWbdir+ NuWxyvni5hzUMLtMudM3aG8pWBaD/TJL5EDMJgMgQ7cXXabtLL3kaegJxrcBgNjVnR35 xH6ZZIBlqyq0Mze9GM3U8sxwp1NcDym4jW1HYegWT+VZ4iYtSbdCrj/JW/b3Xq8ToxJO TW7SapOOfdvrIHKiYnC39g8UXOs6EQpVhI7aHKwnvMhJ8dRuKPWsCqpZ8qBdMBpM4E3q xv7ZLFsCJ4lluWRb504F3aFujkvjw9ZQ5m65CNkDYb2F0tyFZITActhT/BfkKzPzOof4 N/IQ== X-Gm-Message-State: ABuFfojNftHdSuy5dwujSI2shN7Ztxxb/Ndpv/sJ7BOauT31zPWCw4in /sgI8SW87hU6N1aAvgHqxXg= X-Google-Smtp-Source: ACcGV63eGCu/d5BQSwF7ybhcVfSyRQ8xWlqOHL1KtqDy9R9c7Pnv3WBjJSC+JgV+JsVr/Y7b/yXquQ== X-Received: by 2002:a17:902:4e:: with SMTP id 72-v6mr13087199pla.318.1538420018433; Mon, 01 Oct 2018 11:53:38 -0700 (PDT) Received: from garbanzo.do-not-panic.com (c-73-71-40-85.hsd1.ca.comcast.net. [73.71.40.85]) by smtp.gmail.com with ESMTPSA id c69-v6sm21034663pfg.2.2018.10.01.11.53.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Oct 2018 11:53:37 -0700 (PDT) Received: by garbanzo.do-not-panic.com (sSMTP sendmail emulation); Mon, 01 Oct 2018 11:53:33 -0700 Date: Mon, 1 Oct 2018 11:53:33 -0700 From: Luis Chamberlain To: Bjorn Andersson Cc: Niklas Cassel , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, Rishabh Bhatnagar Subject: Re: [PATCH] firmware: Always initialize the fw_priv list object Message-ID: <20181001185333.GH5238@garbanzo.do-not-panic.com> References: <20180920010938.10315-1-bjorn.andersson@linaro.org> <20180920052204.GA15695@kroah.com> <20180920073415.GC1367@tuxbook-pro> <20181001132703.GA12193@centauri.lan> <20181001181835.GG5238@garbanzo.do-not-panic.com> <20181001183216.GM2523@minitux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181001183216.GM2523@minitux> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 01, 2018 at 11:32:16AM -0700, Bjorn Andersson wrote: > On Mon 01 Oct 11:18 PDT 2018, Luis Chamberlain wrote: > > > On Mon, Oct 01, 2018 at 03:27:03PM +0200, Niklas Cassel wrote: > > > On Thu, Sep 20, 2018 at 12:34:15AM -0700, Bjorn Andersson wrote: > > > > On Wed 19 Sep 22:22 PDT 2018, Greg Kroah-Hartman wrote: > > > > > > > > > On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote: > > > > > > When freeing the fw_priv the item is taken off the list. This causes an > > > > > > oops in the FW_OPT_NOCACHE case as the list object is not initialized. > > > > > > > > > > > > Make sure to initialize the list object regardless of this flag. > > > > > > > > > > > > Fixes: 422b3db2a503 ("firmware: Fix security issue with request_firmware_into_buf()") > > > > > > Cc: stable@vger.kernel.org > > > > > > Cc: Rishabh Bhatnagar > > > > > > Signed-off-by: Bjorn Andersson > > > > > > --- > > > > > > drivers/base/firmware_loader/main.c | 7 +++++-- > > > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > Is this being triggered by some hardware somewhere today? Or is this > > > > > just a fix found by code inspection? > > > > > > > > > > > > > Hi Greg, > > > > > > > > Yes, I found this issue while attempting to load the firmware and boot > > > > one of the DSPs on one of my Qualcomm dev boards after v4.19-rc4 and it > > > > can be reproduced on the upstream Dragonboard 820c. > > > > > > I still see this issue on v4.19-rc6. > > > > > > It would be nice if this fix gets merged before v4.19 gets released. > > > > This is the first I hear of this and this patch, so you should re-send > > it and I can review it. Also please Cc Rishabh. > > > > Rishabh, had you heard of this and can you confirm as well as > > 422b3db2a503 was your commit? > > > > Thanks Luis, > > It seems like Greg did pick the patch yesterday [1], so hopefully he > sends himself a pull request this week for inclusion in v4.19-rc7. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/log/?h=char-misc-linus The patch looks good. Next time please send patches to the maintainer as well. Luis